Missed this in code review. In https://phabricator.wikimedia.org/rPWBCee30a681c2b6d389bdbfc01933b73ac052590b55 the _WbDataPage was introduced. def fromWikibase(cls, page_name, site, data_site) is just wrong, this should be def fromWikibase(cls, json, site) . @Lokal_Profil I think the init and fromWikibase got mixed up?
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Clean up issue with _WbDataPage | Lokal Profil | pywikibot/core | master | +2 -3 | |
| Unbreak wbGeoShape and WbTabularData | Multichill | pywikibot/core | master | +3 -2 |
Event Timeline
Comment Actions
From https://github.com/wikimedia/pywikibot-core/commit/ee30a681c2b6d389bdbfc01933b73ac052590b55#diff-9d6a0f7bf454d9a42f89a92d169bf96bR1007 , I think the parameter data_site in fromWikibase can just be dropped.
Comment Actions
Change 355812 had a related patch set uploaded (by Multichill; owner: Multichill):
[pywikibot/core@master] Unbreak wbGeoShape and WbTabularData
Comment Actions
Change 355812 merged by jenkins-bot:
[pywikibot/core@master] Unbreak wbGeoShape and WbTabularData
Comment Actions
I'm not sure the logic is right in the unbreak patch site should always be automatically provided when loading data fromWikibase.
I'll take a closer look at this and what went wrong with the original patch.
Comment Actions
Change 355908 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[pywikibot/core@master] Clean up issue with _WbDataPage
Comment Actions
Change 355908 merged by jenkins-bot:
[pywikibot/core@master] Clean up issue with _WbDataPage
Comment Actions
Fixed. @Multichill thanks for the emergency fix. Your assumption was also correct in that data_site had gotten accidentally copied in from __init__.