Page MenuHomePhabricator

Indicate that the download has started when an article in a reading list is not yet completely offline
Closed, ResolvedPublic

Description

A status indicator is missing for when an article is partially/has not started being downloaded for offline.

Proposed design
1. Show a 'download started' icon on the relevant list item
List - var C.png (1×720 px, 684 KB)
Show a toast when that icon is tapped advising the user that the download is in progress
List - var C.png (1×720 px, 697 KB)

Asset - download-started icon:

NOTE: See subtask T166398 for the UI enhancement to show the progress of each article download

[x] Needs QA

Steps to reproduce for QA

  1. Open the feed
  2. Go into airplane mode
  3. Add an article in the feed to a reading list WITHOUT opening it first
  4. Go to the list where the article was saved

Expected:
There should be an icon indicating that the item is in the process of being made available (but not yet available) offline.
Tapping the icon will show a toast advising user that "Article downloading is in progress, and will resume once you’re back online."

Event Timeline

RHo renamed this task from Indicate downloading in progress when an article in a reading list has not yet been downloaded offline to Indicate that the download has started when an article in a reading list is not yet completely offline.May 26 2017, 6:23 PM
RHo updated the task description. (Show Details)

@RHo A couple questions:

  • By "toast", do you mean Snackbar?
  • The verbiage of the message is a bit confusing: what about if the download is in progress, and you're still online?

Change 361722 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Show improved status indication when page download is in progress.

https://gerrit.wikimedia.org/r/361722

@RHo A couple questions:

  • By "toast", do you mean Snackbar?

I mean toast since there is no way to swipe them off screen, also the styling is toast-y. :D

  • The verbiage of the message is a bit confusing: what about if the download is in progress, and you're still online?

Ah I was under the impression this is only showing as a status indicator when you lose connection in the midst of downloading an article. I guess we can just amend to a general message saying just "Article downloading in progress".

Change 361722 merged by jenkins-bot:
[apps/android/wikipedia@master] Show improved status indication when page download is in progress.

https://gerrit.wikimedia.org/r/361722

LGTM

Screenshot_20170707-190505.png (1×1 px, 520 KB)

Tested on Pixel (Android 7.1.2) Wikipedia v2.6.198-alpha-2017-07-07

ABorbaWMF subscribed.

Tested on Pixel with Android 7.1.1 and Nexus 4 with Android 5.1 on the Alpha App 2.6.198-alpha-2017-07-10

The status indicators are indicating status