Page MenuHomePhabricator

make socket_timeout reusable
Closed, ResolvedPublic

Description

socket_timeout is currently used by comms.http.py to pass it to requests.session.request. Unfortunately older versions of requests accepts a single float (as well as an integer value I guess) whereas newer version uses a tuple of values. Therefor the config.socket_timeout is reconfigurated due to the given requests version.

This socket_timeout should be provide on higher level von pywikibot.comms to be reusable by other comms library parts such as eventstreams to prevent code duplication.

Details

Related Changes in Gerrit:

Event Timeline

Xqt triaged this task as Medium priority.May 30 2017, 5:16 AM

Change 356129 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Make socket_timeout reusable

https://gerrit.wikimedia.org/r/356129

Change 356129 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Make socket_timeout recalculation reusable

https://gerrit.wikimedia.org/r/356129