Clicking [ or ] surrounding a reference throws an error when trying to present the reference drawer
Closed, ResolvedPublic
Actions

Description

When you click the [ or ] of a reference you get an error, because the click handler assumes that you clicked the link, not the surrounding brackets

function showReference( ev, drawer, page ) {
		var urlComponents,
			$dest = $( ev.target ),
			href = $dest.attr( 'href' );

		ev.preventDefault();

		// If necessary strip the URL portion of the href so we are left with the
		// fragment
		urlComponents = href.split( '#' );

^^ ev.target will be text node '[ '. causing href var to be undefined|null causing an error when trying to .split() it.

Replication

*See JS error

Details

	Subject	Repo	Branch	Lines +/-
	Use currentTarget rather than target in ref link click handler	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T154861: Clicking certain references results in infinite spinner on mobile

Event Timeline

TheDJ created this task.May 30 2017, 10:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2017, 10:09 AM

TheDJ mentioned this in T154861: Clicking certain references results in infinite spinner on mobile.May 30 2017, 10:12 AM

ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.May 30 2017, 11:09 AM

Jdlrobson moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.May 30 2017, 4:07 PM

Jdlrobson moved this task from Upcoming to Needs Prioritization on the Web-Team-Backlog board.May 30 2017, 4:15 PM

Seems like a 1 pointer, so adding to sprint.

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.May 30 2017, 6:32 PM

Jdlrobson triaged this task as Medium priority.May 30 2017, 7:10 PM

@TheDJ can you give a page/browser and example? all the '[' I see are children of the link. I can't seem to replicate this.

Jdlrobson moved this task from Needs Design Review to To Do on the Readers-Web-Kanbanana-Board-Old board.May 30 2017, 7:15 PM

See betalabs

<a href="#cite_note-Kirkland_geol_pp.21.E2.80.9350-58"><span>[</span>58<span>]</span></a>

The target will be the span, instead of the parent a element. This is because beta has a different configuration for rendering that element:
https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Cite_reference_link

Not sure how many wiki's in production have non-standard configs like that...

Jdlrobson updated the task description. (Show Details)May 30 2017, 8:58 PM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.May 30 2017, 9:47 PM

Change 356301 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Use currentTarget rather than target in ref link click handler

https://gerrit.wikimedia.org/r/356301

gerritbot added a project: Patch-For-Review.May 30 2017, 9:48 PM

Jdlrobson claimed this task.May 30 2017, 9:48 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.

Change 356301 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use currentTarget rather than target in ref link click handler

https://gerrit.wikimedia.org/r/356301

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).May 31 2017, 8:00 AM

TheDJ moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.May 31 2017, 11:42 AM

I'm pretty confident about this change, but can you do a quick review of functionality relating to references to check this hasn't broken anything related?

Jdlrobson moved this task from Needs Prioritization to 2016-17 Q4 on the Web-Team-Backlog board.May 31 2017, 6:32 PM

I did a quick review using an iphone 7+, a Pixel, and a Nexus 4

I used the dog article on beta: https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog

Clicked through the references. Everything worked.

thank you!

Clicking [ or ] surrounding a reference throws an error when trying to present the reference drawerClosed, ResolvedPublicActions