Page MenuHomePhabricator

Allow search and deletion of files that are not attached to any task
Open, Needs TriagePublic

Description

As a user who often adds and updates many image and media files to Phabricator, I want an easy way to find files that are no longer attached to tasks or being used in Pholio Mocks so that I can delete them.

It would also be great to be able to archive or add a search filter to hide files that are attached to closed tasks.

Event Timeline

RHo created this task.May 30 2017, 1:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2017, 1:30 PM

Hi,

why would you want to delete certain historical data? I don't think we'd want to support deleting information (if we don't talk about illegal content etc).

What is the exact workflow behind this request? Is this about Files or about mockups in Pholio, or both?
Note that it is possible to "Close Mock"s and also restrict a Pholio query to only show open mockups.

to hide files that are attached to closed tasks.

As files can be attached / embedded in numerous tasks, how would that work, and "hide" where exactly (URL welcome)?

RHo added a comment.May 30 2017, 2:44 PM

why would you want to delete certain historical data? I don't think we'd want to support deleting information (if we don't talk about illegal content etc).

Hi @Aklapper – it's for cases where for example I've pasted in a mock as I'm commenting/writing up on a task and realize it needs to be updated (or I've pasted in the incorrect file), since the File is created as soon as I paste in even before the task description/comment is submitted, there are a whole bunch of junk files that have no historical value that I have to go and manually delete one by one.

What is the exact workflow behind this request? Is this about Files or about mockups in Pholio, or both?
Note that it is possible to "Close Mock"s and also restrict a Pholio query to only show open mockups.

As above it is more often that it refers to Files, but also in Mockups in Pholio since it creates a file as soon as I drag something into the Mock, so even if I update it before finishing the "Create" process, that junk file is already added.

to hide files that are attached to closed tasks.

As files can be attached / embedded in numerous tasks, how would that work, and "hide" where exactly (URL welcome)?

This was more a suggestion about enabling advanced search to filter out files that are only attached to closed tasks, I didn't mean to imply explicitly hiding them.

it's for cases where for example I've pasted in a mock as I'm commenting/writing up on a task and realize it needs to be updated (or I've pasted in the incorrect file), since the File is created as soon as I paste in even before the task description/comment is submitted, there are a whole bunch of junk files that have no historical value that I have to go and manually delete one by one.

How / in which specific situations does the existence of these junk files create a problem?

RHo added a comment.May 30 2017, 3:35 PM

One specific situation is it make it harder to find the right file when previous junk instances of that file (with the same name) were created and discarded in the midst of writing a comment on a ticket.
Steps in this scenario:

  1. I've dragged in an "icon.svg" asset to a task I'm commenting on
  2. I realized the icon is not correct and make the necessary changes before dragging the updated "icon.svg" into the ticket to replace the previous one.
  3. Some time passes and someone else requiring the icon searches for it under my name and sees two instances of it in results (the junk one created in step 1 and the updated one in step 2), they have to go in to each one to see which is the correct asset to use.

More generally and philosophically, I would like to be able to more easily identify and bin junk files since they are by definition garbage.

why would you want to delete certain historical data? I don't think we'd want to support deleting information (if we don't talk about illegal content etc).

It is currently possible to delete files. I'm merely suggesting a way to make it easier to identify particular files for deletion/filtering out in searches.

I see. Thanks a lot, I get the usecase now! :)
So this would be a request to add an option "Not Attached to Other Document Types" on https://phabricator.wikimedia.org/file/query/advanced/ .

Restricted Application added a project: Upstream. · View Herald TranscriptMay 30 2017, 5:54 PM
RHo added a comment.May 30 2017, 6:09 PM

Cool, thanks for taking the time to consider and understand. It is probably not a massive use-case but for OCD file-management types like myself, but would be an appreciated addition :)