Page MenuHomePhabricator

[BUG] Multiple instances of feed content are being loaded into the feed when user is offline and taps "Retry"
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Open the Explore feed with some content loaded
  2. Go into airplane mode
  3. Scroll down the feed until seeing the Content cannot be loaded when offline message and tap the "RETRY" button

Expected

No new content is loaded below since the user is still offline.

Actual

  • Same content that was already shown is being repeated
    • the Search bar is being included in this repeated content (there should only be one instance of search on the explore page)

Screenshot_20170530-165729.png (1×1 px, 329 KB)

Occurring on

Pixel (Android 7.1.2)
Wikipedia version 2.5.195-alpha-2017-05-26

Event Timeline

RHo renamed this task from [BUG] Multiple instances of the Search bar are being loaded into the feed when user is offline and taps "Retry" to [BUG] Multiple instances of feed content are being loaded into the feed when user is offline and taps "Retry".May 31 2017, 3:43 PM
RHo added subscribers: Mholloway, Kaartic.

Should T166382 also get fixed as part of this bug?

Change 356467 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Improve feed coordinator logic when offline.

https://gerrit.wikimedia.org/r/356467

Change 356467 merged by jenkins-bot:
[apps/android/wikipedia@master] Improve feed coordinator logic when offline.

https://gerrit.wikimedia.org/r/356467

Tested on Nexus 4 with Android 5.1 and Pixel with Android 7.1 on 2.5.195-alpha-2017-06-05

Looks fixed