Page MenuHomePhabricator

Consolidate edit URLs
Open, LowPublic1 Estimated Story Points

Description

Currently we have a bunch of query string parameters:

  • action=edit
  • veaction=edit
  • veaction=editsource
  • section=N
  • vesection=M

The reason for introducing veaction=edit was to ensure that VE was loaded from the read page, but that is no longer really necessary as we can load VE from action=edit (and even shortcut the edit page php).

The main problem with action=edit is that we don't know which editor the user wants, also veaction=edit won't take you to an edit page for users with VE disabled.

A better system might be to user action=edit&editmode=[visual/source], where editmode indicates the preferred editor for a given link. Only if editmode is not specified to we use the user preference.

Event Timeline

Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

From my point of view, ideally, this should have been ?action=edit optional: &section=N optional: &editor=whatever-you-want-to-override-the-default-with

I like how we have done some consolidation towards getting rid of veaction for instance, but now i just have NWE disable all the time, because often i still need OldWikiEditor and I can't switch between the two for one specific page/action/test..

I like how we have done some consolidation towards getting rid of veaction for instance, but now i just have NWE disable all the time, because often i still need OldWikiEditor and I can't switch between the two for one specific page/action/test..

You are aware that action=submit in the URL will still take you to OWE, even with NWE enabled?

Single Edit Button should make this easier to solve as we could treat ?action=edit links the same as if user pressed Single Edit Button on the target page

BTW maybe this should be solved before T84936: Release VisualEditor-MediaWiki as "1.0"?