Maniphest T166601

Fix CharInsert to not use mw.toolbar.insertTags
Closed, ResolvedPublic
Actions

Description

See also

T85787: CharInsert Extension should use mw.toolbar.insertTags instead of window.insertTags.

Details

	Subject	Repo	Branch	Lines +/-
	Remove dependency upon mw.toolbar	mediawiki/extensions/CharInsert	master	+16 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T31145 Core features that shouldn't be in core (tracking)
		Declined		None	T46915 EditPage.php assumes mediawiki.action.edit module present (breaks mobile)
		Resolved		Jdforrester-WMF	T19653 Classic edit toolbar & edit tools (tracking)
		Resolved		Jdforrester-WMF	T30856 Remove classic edit toolbar from core
		Resolved		Legoktm	T166601 Fix CharInsert to not use mw.toolbar.insertTags

Event Timeline

Jdforrester-WMF created this task.May 30 2017, 6:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2017, 6:37 PM

Liuxinyu970226 subscribed.Sep 8 2017, 11:46 AM

• Whatamidoing-WMF mentioned this in T163929: Support the Editing team in their changes to classic edit toolbar.Sep 18 2017, 9:36 PM

• Elitre subscribed.Sep 20 2017, 6:10 PM

• Whatamidoing-WMF mentioned this in T30856: Remove classic edit toolbar from core.Sep 22 2017, 6:42 PM

He7d3r subscribed.Sep 23 2017, 6:39 PM

I assume James isn't working on this and it looks like a pretty simple fix.

Change 380003 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/CharInsert@master] Remove dependency upon mw.toolbar

https://gerrit.wikimedia.org/r/380003

gerritbot added a project: Patch-For-Review.Sep 23 2017, 8:16 PM

In T166601#3629666, @Legoktm wrote:

I assume James isn't working on this and it looks like a pretty simple fix.

Thanks, it was on my list but I'd not actually done anything. :-)

Change 380003 merged by jenkins-bot:
[mediawiki/extensions/CharInsert@master] Remove dependency upon mw.toolbar

https://gerrit.wikimedia.org/r/380003

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 25 2017, 3:00 PM

Liuxinyu970226 unsubscribed.Sep 25 2017, 3:13 PM

He7d3r updated the task description. (Show Details)Nov 29 2017, 10:06 AM