Hey @cmadeo

There's some fallout from fixing this:

Formerly if you selected "Read More" it would scroll "Read more" header just above the threshold at which the TOC will consider a section "selected". Below is an image before this fix after making "Read more" selection from TOC. The dashed line is roughly where the "selection intersect" line is - so whatever section intersects that dashed line is considered selected:

So, before, if you tapped the TOC button again immediately after selecting "Read more" from the TOC, when the TOC appeared again it would still show "Read more" as being selected.

However, this is not the case after this fix because as you can see below, after selecting "Read more" from the TOC the "Read more" section doesn't rise to the "selection intersect" line:

Tap image for animation:

We can tune this in a few ways... maybe next week.

Thanks for the gif and all of the backstory @Mhurd, let's check in later this week or next. I'm sure we can find a working solution together :)

@cmadeo sounds good thx!

https://github.com/wikimedia/wikipedia-ios/pull/1591

Note to self: remember to add testing criteria for being able to scroll read more to top (tablet, phone, landscape, portrait) and note that we'll want to add this to regression script.

Testing criteria

Phone:

• Load an article
• Scroll to bottom of article
• Portrait
  • Ensure the "Read more" header can be scrolled to near the top of the screen - some padding is added at the very bottom to ensure you can do so
• Landscape
  • Ensure when you scroll to the very bottom of the article you no longer see the extra padding at the very bottom mentioned in the portrait step

Tablet:

• Load an article
• Scroll to bottom of article
• Portrait AND Landscape
  • Ensure the "Read more" header can be scrolled to near the top of the screen - some padding is added at the very bottom to ensure you can do so
  • ^ When testing the above step try it with the table of contents both visible and hidden.

@ABorbaWMF Hey can you add this test to the regression script so TSG runs it each time?

Testing on iPhone 6s (iOS 10.3.3), iPad Air 2 (iOS 10.2) and Wikipedia app 5.6.0 (1171). I haven't noticed any oddities as described when executing the testing (I only tested one article, so feel free to recommend a specific one) but this seems fixed on the latest build.

Tested on iPad Mini Retina with iOS 10.3, and iPhone 7+ with iOS 10.3 on App 5.6.0 (1172)

Looks good