Page MenuHomePhabricator
Create Task
Maniphest T166696

Right-click-drag seems to throw things a bit out of whack
Closed, ResolvedPublic
Actions

Description

I'm not sure if right-clicking is supposed to present a different mode of rotation, but after using it the object seems to spin and rotate together and zoom/pan until I exit the mediaviewer.

Steps:

  1. View a 3D object
  2. Right-click-drag and manipulate the object a bit
  3. Left-click-drag and manipulate the object
  4. Right-click-drag again

Expected Result:
Not sure.

Actual Result:
The object seems to spin and rotate together and zoom/pan until I exit the mediaviewer.

Details

SubjectRepoBranchLines +/-
Re-enable panningmediawiki/extensions/3Dmaster+0 -1
Disable panningmediawiki/extensions/3Dmaster+1 -0
Don't keep forcing the camera to look back at the objectmediawiki/extensions/3Dmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

ABorbaWMF created this task.May 31 2017, 3:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2017, 3:54 PM
dr0ptp4kt added subscribers: • Nirzar, dr0ptp4kt.May 31 2017, 4:22 PM

@Nirzar what is the desired behavior? Anthony mentioned that this normally is a strafing behavior in other 3D scenarios.

dr0ptp4kt added a comment.May 31 2017, 4:22 PM

...by the way, probably an upstream fix whatever the desired behavior.

dr0ptp4kt added projects: Multimedia, Design.May 31 2017, 5:41 PM
dr0ptp4kt assigned this task to • Nirzar.Jun 1 2017, 12:03 AM
dr0ptp4kt triaged this task as High priority.Jun 12 2017, 10:34 PM
dr0ptp4kt moved this task from Untriaged to Next up on the Multimedia board.

Per discussion with @Nirzar let's unbind right-click, and file a bug (or PR) upstream.

dr0ptp4kt removed • Nirzar as the assignee of this task.Jun 13 2017, 7:48 PM
matthiasmullie claimed this task.Jun 20 2017, 9:29 AM
gerritbot subscribed.Jun 20 2017, 10:39 AM

Change 360323 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Don't keep forcing the camera to look back at the object

https://gerrit.wikimedia.org/r/360323

gerritbot added a project: Patch-For-Review.Jun 20 2017, 10:39 AM

Change 360324 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Disable panning

https://gerrit.wikimedia.org/r/360324

matthiasmullie mentioned this in rETHR7888aacd38f4: Don't keep forcing the camera to look back at the object.Jun 20 2017, 10:41 AM
matthiasmullie mentioned this in rETHRacf810a3894f: Disable panning.
matthiasmullie added a comment.Jun 20 2017, 10:49 AM
  • Left: rotate
  • Middle: zoom
  • Right: pan

There's no issue upstream - it all seems to work just fine.
However, whenever we rerender, we force the camera to look back at out object.
When panning, this almost looks like rotating: the camera moves away from the object, but then it looks back, from its new position.
If we then start to rotate our object, it'll be confusing since it appears that our camera is still right in front of our object, when it is not.

We should probably only force our camera to look at the object when we load it, then stop forcing it to look back.
That way, we can have the kind of panning you'd expect (where the camera just "moves to the side")

So now that we know that panning can easily be fixed (patch awaiting review), do we still want to remove it/unbind right click? (trivial, patch is up already)

matthiasmullie moved this task from Next up to Needs Design on the Multimedia board.Jun 20 2017, 10:49 AM
dr0ptp4kt reassigned this task from matthiasmullie to • Nirzar.Jun 26 2017, 3:10 PM
dr0ptp4kt added a subscriber: matthiasmullie.

@Nirzar would you please review?

gerritbot added a comment.Jun 28 2017, 8:37 PM

Change 360323 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Don't keep forcing the camera to look back at the object

https://gerrit.wikimedia.org/r/360323

gerritbot added a comment.Jun 28 2017, 8:37 PM

Change 360324 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Disable panning

https://gerrit.wikimedia.org/r/360324

gerritbot added a comment.Jul 17 2017, 7:13 PM

Change 365683 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Re-enable panning

https://gerrit.wikimedia.org/r/365683

matthiasmullie mentioned this in rETHR5420cafa9e19: Re-enable panning.Jul 17 2017, 7:14 PM
matthiasmullie claimed this task.Jul 19 2017, 5:56 AM
matthiasmullie moved this task from Needs Design to Needs code review on the Multimedia board.
gerritbot added a comment.Jul 20 2017, 2:15 PM

Change 365683 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Re-enable panning

https://gerrit.wikimedia.org/r/365683

dr0ptp4kt moved this task from Needs code review to Needs QA on the Multimedia board.Jul 24 2017, 3:11 PM

@ABorbaWMF would you please validate on Beta Commons?

ABorbaWMF added a comment.Jul 25 2017, 10:58 PM

@dr0ptp4kt Yes it looks good

image.png (768×1 px, 149 KB)

image.png (768×1 px, 156 KB)

dr0ptp4kt closed this task as Resolved.Aug 7 2017, 4:17 PM

Thanks @ABorbaWMF

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL