Looks like data is still logged for this schema but not used, we should remove logging if so. Thanks!
Description
Details
Related Objects
Event Timeline
Background: T67508 broke logging for this schema. Also it's one of two schemas which don't use the standard JS or PHP logging code so somewhat of a maintenance burden in the long run.
Is this tagged with cloud-services-team in error, or is there something you need from us?
@Andrew : you guys own the script that logs this data (i think it was created by Yuvi a while back) . It doesn't seem like it is used
This schema was for finding out about how people used our jsub and webservice commands. We can shut this down. I don't think anyone has even tried to look at the data for over a year. Removing is two part:
- make the Puppet managed helper script a no-op
- remove calls to the helper script from jsub and webserivice
The first would be all that is needed to unblock dropping the schema.
Change 381619 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/toollabs@master] Remove log-command-invocation calls
Change 381712 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[operations/puppet@production] wmcs: Make /usr/local/bin/log-command-invocation a no-op
Change 381713 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[operations/software/tools-webservice@master] Remove Schema:CommandInvocation EventLogging
You can truncate them now if you'd like. I'll update here once we actually get all the callers removed. Until that happens the events will keep coming in.
Change 381712 merged by Andrew Bogott:
[operations/puppet@production] wmcs: Make /usr/local/bin/log-command-invocation a no-op
Change 381619 merged by jenkins-bot:
[labs/toollabs@master] Remove log-command-invocation calls
Change 381713 merged by jenkins-bot:
[operations/software/tools-webservice@master] Remove Schema:CommandInvocation EventLogging
The code has been rolled out everywhere to stop sending events to the eventlogging beacon endpoint. The webservice script was logging directly (not via the /usr/local/bin/log-command-invocation helper). This script is packaged in the Docker containers that Toolforge Kubernetes apps run in, so the old version of the script is still in the wild for all Kubernetes pods that were started before I rebuilt the Docker images. They will get the new version at the next restart of each pod.
I doubt that there is a lot of running of webservice done from inside a running pod, so it should be fairly safe to drop the CommandInvocation table now.
@Nuria Both tables right?
+-------------------------------------+ | Tables_in_log (CommandInvocation%) | +-------------------------------------+ | CommandInvocation_15243810 | | CommandInvocation_15243810_15423246 | +-------------------------------------+
Mentioned in SAL (#wikimedia-operations) [2017-11-03T08:16:37Z] <elukey> drop CommandInvocation_15243810 and CommandInvocation_15243810_15423246 from analytics dbs (db1046/db1047/db1108/dbstore1002) - data archived on HDFS - T166712