Code hygiene ketchup (tracking)
Closed, DeclinedPublic
Actions

Description

This is an experiment introduced from the sprint commencing 31st March 2017.

This task tracks small hygiene tasks associated with reading web projects. It is a lightweight way to tell team members that you have done some opportunistic refactoring.

It can be moved around the Kanban board to reflect code that needs review/needs improvement. It should be considered lower priority compared to other work in the sprint.

The goal is to encourage developers to work on and communicate hygiene tasks they are making. As part of review, if a reviewer deems a task confusing or not clear this task can be used as an opportunity to start conversations/spin off tasks where necessary.

This task should not be removed from the kanban board. It's default home is ToDo. There is always refactoring to be done!

Current hygiene patches requesting review

Needs review

Needs more work

Details

Subject	Repo	Branch	Lines +/-
Hygiene: Stop using deprecated setWarning and dieUsage	mediawiki/extensions/MobileFrontend	master	+13 -43
Hygiene: Interwiki::getAllPrefixes() is deprecated use MediaWikiServices instead	mediawiki/extensions/MobileFrontend	master	+2 -1
Hygiene: ParseCache::singleton() is deprecated, use MediaWikiServices instead	mediawiki/extensions/MobileFrontend	master	+2 -1
Hygiene: Remove deprecation and unused import	mediawiki/extensions/TextExtracts	master	+11 -19

Customize query in gerrit

Related Objects

Mentioned In: T174412: Phlogiston Bug: ParentTask set to false in recat still shows in Status Report
Mentioned Here: T173800: Do not load the JavaScript editor for non wikitext pages

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 29 2017, 6:20 PM

Jdlrobson updated the task description. (Show Details)

phuedx moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 3 2017, 2:01 PM

phuedx updated the task description. (Show Details)

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 3 2017, 4:19 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Jul 6 2017, 7:26 PM

• bmansurov updated the task description. (Show Details)Jul 6 2017, 9:54 PM

• bmansurov updated the task description. (Show Details)Jul 6 2017, 11:12 PM

• bmansurov moved this task from Needs Code Review to To Do on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 6 2017, 11:24 PM

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 10 2017, 3:56 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Jul 11 2017, 6:36 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 12 2017, 12:31 AM

pmiazga updated the task description. (Show Details)Jul 24 2017, 2:35 PM

pmiazga subscribed.

pmiazga updated the task description. (Show Details)Jul 24 2017, 3:04 PM

pmiazga updated the task description. (Show Details)

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 24 2017, 3:40 PM

Jdlrobson updated the task description. (Show Details)Jul 24 2017, 3:58 PM

Jdlrobson updated the task description. (Show Details)Jul 26 2017, 4:25 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 1 2017, 7:01 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Aug 1 2017, 11:23 PM

Change 369645 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/TextExtracts@master] Hygiene: Remove deprecation and unused import

https://gerrit.wikimedia.org/r/369645

gerritbot added a project: Patch-For-Review.Aug 2 2017, 1:25 PM

pmiazga updated the task description. (Show Details)Aug 2 2017, 1:26 PM

Change 369650 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: Stop using deprecated setWarning and dieUsage

https://gerrit.wikimedia.org/r/369650

pmiazga updated the task description. (Show Details)Aug 2 2017, 1:52 PM

Change 369654 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: ParseCache::singleton() is deprecated, use MediaWikiServices instead

https://gerrit.wikimedia.org/r/369654

pmiazga updated the task description. (Show Details)Aug 2 2017, 2:03 PM

Change 369657 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: Interwiki::getAllPrefixes() is deprecated use MediaWikiServices instead

https://gerrit.wikimedia.org/r/369657

pmiazga updated the task description. (Show Details)Aug 2 2017, 2:08 PM

• Jhernandez unsubscribed.Aug 2 2017, 3:29 PM

pmiazga moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 2 2017, 5:06 PM

I've got a minor request for clarification on https://gerrit.wikimedia.org/r/369650 :

This is a big support jump (from 1.27 to 1.29). It is warranted? Was there any reason we were trying to support 1.27?

Jdlrobson updated the task description. (Show Details)Aug 3 2017, 9:30 PM

Jdlrobson updated the task description. (Show Details)

Change 369654 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: ParseCache::singleton() is deprecated, use MediaWikiServices instead

https://gerrit.wikimedia.org/r/369654

Change 369657 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: Interwiki::getAllPrefixes() is deprecated use MediaWikiServices instead

https://gerrit.wikimedia.org/r/369657

Change 369645 merged by jenkins-bot:
[mediawiki/extensions/TextExtracts@master] Hygiene: Remove deprecation and unused import

https://gerrit.wikimedia.org/r/369645

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)).Aug 3 2017, 10:00 PM

Jdlrobson updated the task description. (Show Details)Aug 3 2017, 10:44 PM

pmiazga moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 7 2017, 5:06 PM

@pmiazga has replied according to standup update

@Jdlrobson the real question is what do we want to support? Do want to support the oldest possible MediaWiki version always, even we have to add tricks like:

if ( method_exists( 'somefunction', 'someclass' ) ) {
   do_it_new_way();
} else {
   do_it_old_way();
}

Everytime there is a new release we do a branch cut on all extensions, Also is there any procedure to verify that after all changes introduced in last year MF still works properly on 1.27?

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Aug 7 2017, 7:08 PM

Change 369650 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: Stop using deprecated setWarning and dieUsage

https://gerrit.wikimedia.org/r/369650

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 7 2017, 8:27 PM

Jdlrobson updated the task description. (Show Details)

• bmansurov updated the task description. (Show Details)Aug 8 2017, 2:25 PM

• bmansurov moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson removed a project: Patch-For-Review.Aug 8 2017, 2:58 PM

I don't want to bring T173800 into the sprint as I think it will cause confusion (i've only fixed part of it ) and it is not a priority, but if anyone has some spare cycles I'd appreciate a review of https://gerrit.wikimedia.org/r/373076. I believe this will improve things considerably for the Wikisource community and given it is not a trivial change I'd like to run it by at least one person.