Page MenuHomePhabricator

Migrate Minerva skin to new home
Closed, DuplicatePublic

Description

When the script from T166744 is available, we will run it to pull the Minerva code from MobileFrontend into its new home. When doing this we need to be careful not to break anything.

For the time being the new skin will be dependent on MobileFrontend.

Precursors

  • A dormant version of MinervaNeue skin is deployed to the cluster. It doesn't do anything (yet)

Developer notes

Porting Minerva code from MobileFrontend to Minerva:

  • Make sure this repository is in your MediaWiki skins directory
  • Make sure MobileFrontend is installed in extensions/MobileFrontend in your MediaWiki install
  • Create commits for both MobileFrontend and Minerva to handle the move.
  • Run:

> python3 scripts/migrate.py

Acceptance criteria

  • After running the script MobileFrontend complains that no mobile skin has been setup
  • When using wfLoadSkin('MinervaNeue') everything should work as per normal.

Post merge:

  • Rename message keys to have minerva- prefix
  • Update includes/Minerva.ServiceWiring.php makeConfig call to call minerva
  • Setup task to break the MobileFrontend/Minerva dependency

Related Objects

StatusSubtypeAssignedTask
DuplicateNone
ResolvedJdlrobson

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2017, 11:37 PM
Jdlrobson updated the task description. (Show Details)Jun 1 2017, 6:22 PM
Jdlrobson updated the task description. (Show Details)
Nemo_bis added a subscriber: Raymond.
Nemo_bis added a subscriber: Nemo_bis.
Jdlrobson updated the task description. (Show Details)Jun 1 2017, 6:54 PM

Change 362448 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Minerva is its own skin

https://gerrit.wikimedia.org/r/362448

Change 362451 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Give MinervaNeue control of the minerva skin name

https://gerrit.wikimedia.org/r/362451