Migrate Minerva skin to new home
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	May 31 2017, 11:37 PM

Description

When the script from T166744 is available, we will run it to pull the Minerva code from MobileFrontend into its new home. When doing this we need to be careful not to break anything.

For the time being the new skin will be dependent on MobileFrontend.

Precursors

A dormant version of MinervaNeue skin is deployed to the cluster. It doesn't do anything (yet)

Developer notes

Porting Minerva code from MobileFrontend to Minerva:

Make sure this repository is in your MediaWiki skins directory
Make sure MobileFrontend is installed in extensions/MobileFrontend in your MediaWiki install
Create commits for both MobileFrontend and Minerva to handle the move.
Run:

> python3 scripts/migrate.py

Acceptance criteria

After running the script MobileFrontend complains that no mobile skin has been setup
When using wfLoadSkin('MinervaNeue') everything should work as per normal.

Post merge:

Rename message keys to have minerva- prefix
Update includes/Minerva.ServiceWiring.php makeConfig call to call minerva
Setup task to break the MobileFrontend/Minerva dependency

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Duplicate		None	T166747 Migrate Minerva skin to new home
		Resolved		Jdlrobson	T166744 Add migration script

Event Timeline

Jdlrobson created this task.May 31 2017, 11:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2017, 11:37 PM

Jdlrobson added a subtask: T166744: Add migration script.May 31 2017, 11:37 PM

Jdlrobson updated the task description. (Show Details)Jun 1 2017, 6:22 PM

Jdlrobson updated the task description. (Show Details)

Nemo_bis awarded a token.Jun 1 2017, 6:30 PM

Nemo_bis added a subscriber: Raymond.

Nemo_bis subscribed.

Jdlrobson updated the task description. (Show Details)Jun 1 2017, 6:54 PM

Jdlrobson moved this task from Backlog to Code organisation on the MinervaNeue board.Jun 8 2017, 7:17 PM

Change 362448 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Minerva is its own skin

https://gerrit.wikimedia.org/r/362448

gerritbot added a project: Patch-For-Review.Jun 30 2017, 6:12 PM

Change 362451 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Give MinervaNeue control of the minerva skin name

https://gerrit.wikimedia.org/r/362451

Jdlrobson closed this task as a duplicate of T166748: Deploy the MinervaNeue skin to cluster and remove code from MobileFrontend.Jun 30 2017, 6:38 PM

Jdlrobson closed subtask T166744: Add migration script as Resolved.Jun 30 2017, 9:27 PM