Fix scoped DB lock nesting issues in Category::refreshCounts()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Jun 1 2017, 5:09 AM

Description

A regression from the fix for T162121 is that cases in refreshLinks and deleteLinksUpdate cause failure like " Category::refreshCounts: Cannot flush pre-lock snapshot because writes are pending (WikiPage::updateCategoryCounts)" because writes are pending while refreshCounts() tries to clear the transaction and a acquire a named lock.

This causes the updates to never happen.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	REL1_29	+9 -2	Avoid scoped lock errors in Category::refreshCounts() due to nesting
	mediawiki/core	master	+9 -2	Avoid scoped lock errors in Category::refreshCounts() due to nesting

Customize query in gerrit

Related Objects

Mentioned Here: T162121: Contention on enwiki master-categorylinks on Category::refreshCounts

Event Timeline

aaron created this task.Jun 1 2017, 5:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2017, 5:09 AM

Change 356520 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Avoid scoped lock errors in Category::refreshCounts() due to nesting

https://gerrit.wikimedia.org/r/356520

gerritbot added a project: Patch-For-Review.Jun 1 2017, 5:18 AM

Aklapper added a project: MediaWiki-General.Jun 1 2017, 9:54 AM

Aklapper edited projects, added MediaWiki-Categories; removed MediaWiki-General.

aaron moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Jun 1 2017, 5:21 PM

Change 356520 merged by jenkins-bot:
[mediawiki/core@master] Avoid scoped lock errors in Category::refreshCounts() due to nesting

https://gerrit.wikimedia.org/r/356520

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 3 2017, 12:00 AM

aaron closed this task as Resolved.Jun 5 2017, 6:13 AM

aaron triaged this task as High priority.

Change 376745 had a related patch set uploaded (by Martineznovo; owner: Aaron Schulz):
[mediawiki/core@REL1_29] Avoid scoped lock errors in Category::refreshCounts() due to nesting

https://gerrit.wikimedia.org/r/376745

Change 376745 merged by jenkins-bot:
[mediawiki/core@REL1_29] Avoid scoped lock errors in Category::refreshCounts() due to nesting