[Bug] Shortcut for autocompletion broken on WDQS
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lea_Lacroix_WMDE
	Jun 1 2017, 8:02 AM

Description

Just noticed this morning that the Ctrl+Space shortcut that allows autocompletion on the Wikidata Query Service doesn't work anymore.
Tested by one user on Firefox53/Windows, tested by me on Firefox52 and Chromium/Linux.

Details

	Subject	Repo	Branch	Lines +/-
	Fix extraKeys configuration	wikidata/query/gui	master	+5 -11

Customize query in gerrit

Related Objects

Mentioned In: rWDQG891bc9a44d01: Fix extraKeys configuration
Mentioned Here: rWDQGa5a4e477919b: Map tab key to indent with spaces.

Event Timeline

Lea_Lacroix_WMDE created this task.Jun 1 2017, 8:02 AM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJun 1 2017, 8:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

git bisect says it’s a5a4e477919b19b62d39e88f8ea309d55c963bb7, which seems plausible (affected key bindings).

Yes, can confirm that.

Yes, of course – it overrides extraKeys instead of appending to it.

Change 356550 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Fix extraKeys configuration

https://gerrit.wikimedia.org/r/356550

gerritbot added a project: Patch-For-Review.Jun 1 2017, 8:55 AM

Lucas_Werkmeister_WMDE mentioned this in rWDQG891bc9a44d01: Fix extraKeys configuration.Jun 1 2017, 8:56 AM

• Jonas added a subscriber: Jakob_WMDE.Jun 1 2017, 8:59 AM

Change 356550 merged by jenkins-bot:
[wikidata/query/gui@master] Fix extraKeys configuration

https://gerrit.wikimedia.org/r/356550