Page MenuHomePhabricator

[Bug] Shortcut for autocompletion broken on WDQS
Closed, ResolvedPublic

Description

Just noticed this morning that the Ctrl+Space shortcut that allows autocompletion on the Wikidata Query Service doesn't work anymore.
Tested by one user on Firefox53/Windows, tested by me on Firefox52 and Chromium/Linux.

Details

Related Gerrit Patches:
wikidata/query/gui : masterFix extraKeys configuration

Event Timeline

Restricted Application added a project: Discovery. · View Herald TranscriptJun 1 2017, 8:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

git bisect says it’s a5a4e477919b19b62d39e88f8ea309d55c963bb7, which seems plausible (affected key bindings).

Jonas triaged this task as High priority.Jun 1 2017, 8:40 AM

Yes, can confirm that.

Yes, of course – it overrides extraKeys instead of appending to it.

Change 356550 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Fix extraKeys configuration

https://gerrit.wikimedia.org/r/356550

Change 356550 merged by jenkins-bot:
[wikidata/query/gui@master] Fix extraKeys configuration

https://gerrit.wikimedia.org/r/356550

Jonas closed this task as Resolved.Jun 1 2017, 7:42 PM
Jonas claimed this task.
Jonas moved this task from All WDQS-related tasks to GUI on the Wikidata-Query-Service board.
Jonas added a subscriber: Gehel.

Fix has been deployed.
Thanks @Lucas_Werkmeister_WMDE and @Gehel for your help!