Page MenuHomePhabricator
Create Task
Maniphest T166820

Change places search string to "Search Places"
Closed, ResolvedPublic
Actions

Description

The general search box says "Search Wikipedia", so for clarity/parallelism I propose "Search Places" as the placeholder string on the Places search box.

Related Objects

Event Timeline

• JMinor created this task.Jun 1 2017, 6:19 PM
Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptJun 1 2017, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• JMinor triaged this task as Medium priority.Jun 1 2017, 6:20 PM
• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.
• NHarateh_WMF claimed this task.Jun 1 2017, 6:36 PM
• NHarateh_WMF added a comment.Jun 1 2017, 9:20 PM

This must have been resolved cause I'm seeing "Search" @JMinor :)

Screen Shot 2017-06-01 at 17.18.21.png (692×378 px, 189 KB)

• JMinor added a comment.Jun 1 2017, 9:26 PM

But I want "Search Places" ;)

JoeWalsh mentioned this in rAPIOS9e475ddeb421: Merge pull request #1496 from nambatee/bug/T166820.Jun 2 2017, 10:40 AM
JoeWalsh moved this task from Ready for Development to Needs Testing Criteria on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.Jun 2 2017, 11:18 AM
• NHarateh_WMF moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.Jun 2 2017, 3:18 PM

Testing criteria:

  1. Load the app
  2. Tap "Places"
  3. Ensure the search box says "Search Places"
ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.Jun 2 2017, 8:10 PM
ABorbaWMF subscribed.

Tested on iPhone 7+ with iOS 10.3.2, iPhone 5s with iOS 10.2, and iPad Mini 2 Retina on 10.2.1 on App version 5.5.0 (1145)

Fixed

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Jun 12 2017, 6:56 PM
• JMinor moved this task from Bug Backlog to Product Backlog on the Wikipedia-iOS-App-Backlog board.
• JMinor closed this task as Resolved.Jun 12 2017, 7:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL