Maniphest T166840

Adjust the alignment of the "current location" button to be optically centered
Closed, ResolvedPublic
Actions

Description

The optical alignment of the 'current location' icon appears to be slightly off.
It should be pushed down 1px and shifted left by 1px.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		JoeWalsh	T130889 [EPIC] Improve user access and usage of "Nearby" articles
		Resolved		• JMinor	T158348 Perform user testing of Places feature
		Resolved		JoeWalsh	T166840 Adjust the alignment of the "current location" button to be optically centered

Event Timeline

cmadeo created this task.Jun 1 2017, 9:34 PM

Restricted Application edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (Design). · View Herald TranscriptJun 1 2017, 9:34 PM

cmadeo removed a project: Epic.Jun 2 2017, 12:13 AM

JoeWalsh claimed this task.Jun 2 2017, 12:00 PM

JoeWalsh moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.

@cmadeo 0.5pt (generally 1 px retina) or 1pt (generally 2px retina)?

JoeWalsh moved this task from Doing to Needs Code Review on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.Jun 2 2017, 12:04 PM

JoeWalsh mentioned this in rAPIOSfbac09739f91: Merge branch 'bug/T166840' into beta.Jun 2 2017, 1:23 PM

Diffusion mentioned this in rAPIOSae9ddc7ffe2b: Merge pull request #1498 from wikimedia/bug/T166840.Jun 2 2017, 2:56 PM

Oof, falling back on old ways there, sorry. Let's try the 1px retina (.5pt).

JoeWalsh moved this task from Needs Code Review to Needs Design Review on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.Jun 5 2017, 7:57 PM

Looks good! Thanks!

Tested on iPhone 7+ with iOS 10.3.2, iPhone 5s with iOS 10.2, and iPad Mini 2 Retina on 10.2.1 on App version 5.5.0 (1149)

Fixed

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Jun 12 2017, 6:55 PM

• JMinor closed this task as Resolved.Jun 12 2017, 7:13 PM