Page MenuHomePhabricator

ChangesListSpecialPage backend: Bypass defaults if urlversion=2
Closed, ResolvedPublic

Description

Currently, defaults are always considered, with URL parameters overriding them.

However, we would like to make URLs portable spatially, temporally, and interpersonally, so if urlversion=2 is specified, it should ignore defaults for hide_unselected_if_any and string_options. Instead, the de-minimis default will be "don't hide" (false or ALL, depending on type). (Others like namespace and tag already have a default of "don't hide").

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2017, 8:38 PM

Change 358157 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] ChangesListSpecialPage: Add urlversion and make urlversion=2 ignore defaults

https://gerrit.wikimedia.org/r/358157

Change 358157 merged by jenkins-bot:
[mediawiki/core@master] ChangesListSpecialPage: Add urlversion and make urlversion=2 ignore defaults

https://gerrit.wikimedia.org/r/358157

Checked in betalabs. The one of the cases for copied (bookmarked) urls between User 1 (RC filters are not enabled) and User 2 (enabled filters) described below:

User 1:

  • Filters are not enabled Recent changes preference settings:
  • enabled "Hide categorization of pages"
  • "Days to show in recent changes" 11
  • "Number of edits to show in recent changes ... " 47
  • enabled "Highlight likely problem edits with colors and an "r" for "needs review"...
  • enabled "Show only likely problem edits (and hide probably good edits)"

The default for RC page looks like: https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges

User 2:

  • Filters are enabled

Recent changes preference settings:

  • "Days to show in recent changes" 7
  • "Number of edits to show in recent changes ... " 50
  • enabled "Hide categorization of pages"

The default url on RC page looks like the following: https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&urlversion=2

Copying User 1 default url for RC page ( https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges) will display the default for User 2 (https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&urlversion=2)

When some options on Rc page are modified - e.g. 500 (limit=500) or/and hide registered users (&hideliu=1), the url will successfully display the correct result set when copied even between a user with enabled RC filters and a user with disabled Rc filters.

QA Recommendation: Resolve

jmatazzoni closed this task as Resolved.Jul 14 2017, 6:25 PM