Page MenuHomePhabricator
Create Task
Maniphest T166951

Tag detection is broken
Closed, ResolvedPublic
Actions

Description

2017-06-03 14:11:27,387 - wikibugs.wb2-phab - ERROR - Could not retrieve tags for OrderedDict([('PHID-XACT-TASK-4virr3rf4nt6ejr', 'PHID-XACT-TASK-4virr3rf4nt6ejr'), ('PHID-XACT-TASK-qtu6wfadj5vsecx', 'PHID-XACT-TASK-qtu6wfadj5vsecx')])
Traceback (most recent call last):

File "/data/project/wikibugs/wikibugs2/wikibugs.py", line 236, in process_event
  projects = self.get_tags(task_page)
File "/data/project/wikibugs/wikibugs2/wikibugs.py", line 152, in get_tags
  shade = [cls.split("-")[3] for cls in classes if cls.startswith("phui-tag-shade-")][0]

IndexError: list index out of range

Related Objects

Event Timeline

valhallasw created this task.Jun 3 2017, 2:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2017, 2:13 PM
valhallasw added a comment.Jun 3 2017, 2:20 PM

Changed [cls.split("-")[3] for cls in classes if cls.startswith("phui-tag-shade-")][0] to [cls.split("-")[-1] for cls in classes if cls.startswith("phui-tag-shade")][0] to support tags that are simply 'phui-tag-shade'. From what I can see, there is no way yet to do this cleanly/easily via the API.

valhallasw closed this task as Resolved.Jun 3 2017, 2:26 PM
valhallasw claimed this task.
Krinkle subscribed.Jun 5 2017, 6:27 PM

I think this broke the color detection. As of last few days, all tags are blue on IRC regardless of the tag's actual color.

Screen Shot 2017-06-05 at 20.26.19.png (1,984×314 px, 190 KB)

Screen Shot 2017-06-05 at 20.26.34.png (456×222 px, 28 KB)
Screen Shot 2017-06-05 at 20.26.38.png (542×320 px, 38 KB)
Krinkle reopened this task as Open.Jun 5 2017, 6:27 PM
valhallasw removed valhallasw as the assignee of this task.Mar 19 2019, 8:29 PM

Unassigning; if anyone wants to pick this up they are more than welcome, but it's not on my radar to fix.

• bd808 mentioned this in T357828: All phabricator tags emitted with blue color.Feb 16 2024, 10:03 PM
• bd808 closed this task as Resolved.Feb 16 2024, 10:06 PM
• bd808 assigned this task to valhallasw.
• bd808 subscribed.

I split T357828: All phabricator tags emitted with blue color into it's own bug report. That regression may have started with the fix @valhallasw made for the parse error, but it i very much it's own problem at this point.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits