As noted on https://gerrit.wikimedia.org/r/#/c/321359/ , it would be nice if all the password classes had tests. Current coverage is 22% of lines, although something funny is going on there since even some classes that have their own tests are marked as untested.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Improve test coverage in includes/password | mediawiki/core | master | +338 -14 |
Event Timeline
Comment Actions
although something funny is going on there since even some classes that have their own tests are marked as untested.
Because we have forceCoversAnnotation="true" in tests/phpunit/suite.xml, it ignores coverage that isn't explicitly declared using [[https://phpunit.de/manual/4.8/en/appendixes.annotations.html#appendixes.annotations.covers|a @covers annotation]] on the test class or method.
Comment Actions
Change 357338 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Improve test coverage in includes/password
Comment Actions
Change 357338 merged by jenkins-bot:
[mediawiki/core@master] Improve test coverage in includes/password