Page MenuHomePhabricator

Improve test coverage in includes/password
Closed, ResolvedPublic

Description

As noted on https://gerrit.wikimedia.org/r/#/c/321359/ , it would be nice if all the password classes had tests. Current coverage is 22% of lines, although something funny is going on there since even some classes that have their own tests are marked as untested.

Event Timeline

tstarling created this task.Jun 5 2017, 6:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2017, 6:58 AM
Anomie added a subscriber: Anomie.Jun 5 2017, 1:45 PM

although something funny is going on there since even some classes that have their own tests are marked as untested.

Because we have forceCoversAnnotation="true" in tests/phpunit/suite.xml, it ignores coverage that isn't explicitly declared using [[https://phpunit.de/manual/4.8/en/appendixes.annotations.html#appendixes.annotations.covers|a @covers annotation]] on the test class or method.

Change 357338 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Improve test coverage in includes/password

https://gerrit.wikimedia.org/r/357338

Change 357338 merged by jenkins-bot:
[mediawiki/core@master] Improve test coverage in includes/password

https://gerrit.wikimedia.org/r/357338

tstarling closed this task as Resolved.Jun 8 2017, 2:22 AM