Re-fix "Inserting a reference sometimes breaks horribly (due to trees in TransactionProcessor?)"
Closed, ResolvedPublic8 Story Points

Description

The patch that fixed T165965: [Regression pre-.2] Inserting a reference sometimes breaks horribly (due to trees in TransactionProcessor?) was reverted at some point. This should be fixed again some other way.

Deskana created this task.Jun 5 2017, 2:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2017, 2:43 PM

Change 355605 had a related patch set uploaded (by Deskana; owner: Divec):
[VisualEditor/VisualEditor@master] TreeModifier: incremental linear splices to match tree modifications

https://gerrit.wikimedia.org/r/355605

Change 357171 had a related patch set uploaded (by Deskana; owner: Divec):
[VisualEditor/VisualEditor@master] TransactionProcessor: modify DM tree branches instead of rebuilding them

https://gerrit.wikimedia.org/r/357171

Deskana triaged this task as Normal priority.Jun 5 2017, 2:54 PM
Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Deskana added a subscriber: dchan.

Setting priority. @dchan, let me know if you disagree. :-)

Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Not interrupt (code's not broken yet). ;-) Putting into the dependency tree.

Change 357171 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TransactionProcessor: modify DM tree branches instead of rebuilding them

https://gerrit.wikimedia.org/r/357171

Change 376396 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (834fd702f)

https://gerrit.wikimedia.org/r/376396

Change 376396 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (834fd702f)

https://gerrit.wikimedia.org/r/376396

Deskana closed this task as Resolved.Sep 7 2017, 11:42 AM
Deskana assigned this task to dchan.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 7 2017, 11:42 AM