[Regression pre-wmf.4] Vector's personal tools are appearing above OOjs UI's global overlay ... again
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Jun 5 2017, 4:39 PM

Description

It looks like Vector/skinStyles/ooui.less isn't getting loaded, maybe a change in ResourceLoader?

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+43 -3	Restore the ability to set $wgResourceModuleSkinStyles for 'oojs-ui-core.styles'

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	demon	T166829 MW-1.30.0-wmf.4 deployment blockers
Resolved	matmarex	T167042 [Regression pre-wmf.4] Vector's personal tools are appearing above OOjs UI's global overlay ... again
Resolved	matmarex	T167216 $wgResourceModuleSkinStyles customizations are not being applied for Vector because MobileFrontend accidentally overrides them

Event Timeline

Esanders created this task.Jun 5 2017, 4:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2017, 4:39 PM

Esanders triaged this task as High priority.Jun 5 2017, 4:39 PM

Jdforrester-WMF added a parent task: T166829: MW-1.30.0-wmf.4 deployment blockers.Jun 5 2017, 4:40 PM

Bisect blames https://gerrit.wikimedia.org/r/#/c/343238/ (@matmarex)

matmarex claimed this task.Jun 5 2017, 4:46 PM

Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.Jun 5 2017, 5:01 PM

Jdforrester-WMF renamed this task from Personal tools appearing above global overlay ... again to [Regression pre-wmf.4] Vector's personal tools are appearing above OOjs UI's global overlay ... again.Jun 5 2017, 5:02 PM

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF mentioned this in T167053: [Regression pre-wmf.4] Dialog buttons on the top are getting hidden under the VE toolbar upon resizing the window .Jun 5 2017, 6:02 PM

Change 357241 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Restore the ability to set $wgResourceModuleSkinStyles for 'oojs-ui-core.styles'

https://gerrit.wikimedia.org/r/357241

gerritbot added a project: Patch-For-Review.Jun 5 2017, 7:31 PM

Change 357241 merged by jenkins-bot:
[mediawiki/core@master] Restore the ability to set $wgResourceModuleSkinStyles for 'oojs-ui-core.styles'

https://gerrit.wikimedia.org/r/357241

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 6 2017, 3:00 AM

Not fixed in master or wmf.4 yet.

There also seems to be a module loading issue at T167216, maybe related.

greg added a subscriber: greg.Jun 6 2017, 9:51 PM

This is definitely resolved for the specific case, but apparently somehow all $wgResourceModuleSkinStyles customizations are broken for Vector, see T167216.

matmarex added a subtask: T167216: $wgResourceModuleSkinStyles customizations are not being applied for Vector because MobileFrontend accidentally overrides them.Jun 7 2017, 2:31 PM

mmodell closed subtask T167216: $wgResourceModuleSkinStyles customizations are not being applied for Vector because MobileFrontend accidentally overrides them as Resolved.Jun 7 2017, 8:33 PM

mmodell closed this task as Resolved.Jun 7 2017, 8:39 PM

Volker_E moved this task from Backlog to Waiting for breaking release on the OOUI board.Jul 17 2017, 5:54 PM

Volker_E moved this task from Waiting for breaking release to Resolved outside releases on the OOUI board.Mar 22 2018, 5:41 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 22 2018, 5:41 AM