Page MenuHomePhabricator

Fix iOS initial viewport scale calculation bugs
Closed, ResolvedPublic

Description

Combination of unset initial viewport scale and CSS override hack prevented proper initial viewport width calculation on pages containing super-wide elements.

Note that this does not fix the upstream "graphs-not-being-mobile-friendly" issues from T161405, but it does make issues like this far less explode-y on iOS.

Examples:
enwiki > Lagrangian point
frwiki > Liste de sondages sur l'élection présidentielle française de 2017

(Edit: see the PR for before/after images.)

Event Timeline

Testing criteria

  • with English as the search language, load the Lagrangian point article and ensure it looks like the first image below not the second one

27ae757a-4a1b-11e7-94b0-36585fcab9c9.png (1×862 px, 318 KB)

b545de28-4a1b-11e7-904d-5c1fac3d75ba.png (1×862 px, 336 KB)

  • with French as the search language, load the Liste de sondages sur l'élection présidentielle française de 2017 article and ensure it looks like the first image below not the second one

dca41c8c-4a1b-11e7-80a5-899e09dd617c.png (1×862 px, 199 KB)

b27de8c0-4a1b-11e7-8e06-b2e6fa2d0fcf.png (1×862 px, 254 KB)

Testing on iPhone 6s (iOS 10.3.2) and iPhone 7 (iOS 10.3.1), and Wikipedia app 5.5.0 (1149). This is fixed as the screencaps below look correct.

T167082 English.PNG (1×750 px, 300 KB)
T167082 French.PNG (1×750 px, 132 KB)