RESTBase page summary endpoint includes a body in 304 response
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	phuedx
	Jun 6 2017, 3:26 PM

Description

Revalidation requests to the RESTBase page summary endpoint have a body. AFAIK an HTTP 304 response doesn't require a body.

When dwelling on the same link multiple times I see:

An HTTP 200 response for the first request, which contains the preview.
An HTTP 304 response for the second...Nth requests, which also contain the preview.

e.g. (with cookies and the x-analytics headers stripped) {P5549}

Notes

I noticed that Page Previews sends a broken Accept header with each request. This is fixed in rEPOPbd53dd13822a: gateway: Fix Accept header sent by rest gateway. Could RESTBase think that we're requesting the latest version of the preview every time we make the request?

Related Objects

Mentioned Here: rEPOPbd53dd13822a: gateway: Fix Accept header sent by rest gateway

Event Timeline

phuedx created this task.Jun 6 2017, 3:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2017, 3:26 PM

Hm.. RESTBase never actually sends 304, so it's either Varnish or potentially the browser. We allow 5 minutes client-side caching, maybe the browser returns this?

@Pchelolo: RESTBase will not send 304s?

RESTBase will not send 304s?

RESTBase itself is not sending 304. 304 here is sent by Varnish because you've got an if-none-match header in the second request.

'course.

Jdlrobson added a project: Web-Team-Backlog.Jun 6 2017, 10:04 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

@Pchelolo: Who's the best person to ask about the Varnish configuration for RESTBase?

Who's the best person to ask about the Varnish configuration for RESTBase?

@BBlack

ovasileva moved this task from Needs Prioritization to 2014-15 Q4 on the Web-Team-Backlog board.Jun 13 2017, 4:21 PM

ovasileva moved this task from Backlog to Needs Analysis on the Page-Previews board.Jun 20 2017, 1:06 PM

ovasileva moved this task from Needs Analysis to incoming on the Page-Previews board.

Jdlrobson moved this task from 2014-15 Q4 to Tracking on the Web-Team-Backlog board.Jun 29 2017, 8:20 PM

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

Jdlrobson moved this task from Untriaged to Move to Backlog on the Web-Team-Backlog (Tracking) board.Jun 29 2017, 8:24 PM

Jdlrobson moved this task from incoming to Backlog on the Page-Previews board.Jul 19 2017, 3:35 PM

ovasileva moved this task from Backlog to incoming on the Page-Previews board.Mar 15 2018, 3:56 PM

Jdlrobson moved this task from incoming to Tracking on the Page-Previews board.Apr 14 2021, 6:49 PM

Jdlrobson edited projects, added Page-Previews (Tracking); removed Page-Previews.

Jdlrobson moved this task from Move to Backlog to Untriaged on the Web-Team-Backlog (Tracking) board.Sep 7 2021, 9:06 PM

Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 7 2021, 9:09 PM

LGoto removed a project: Web-Team-Backlog (Tracking).Nov 9 2021, 4:23 PM

RESTBase page summary endpoint includes a body in 304 responseOpen, Needs TriagePublicActions

Description

Notes

Related Objects

Event Timeline

RESTBase page summary endpoint includes a body in 304 response
Open, Needs TriagePublic
Actions