Page MenuHomePhabricator
Create Task
Maniphest T167216

$wgResourceModuleSkinStyles customizations are not being applied for Vector because MobileFrontend accidentally overrides them
Closed, ResolvedPublic
Actions

Description

The preferences page on Test Wikipedia has no tabs and doesn't have the logo overlay: https://test.wikipedia.org/wiki/Special:Preferences

The issue is also visible on the beta cluster: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences

Screen Shot 2017-06-06 at 2.08.10 PM.png (745×1 px, 146 KB)

Can't reproduce locally. Seems likely there is some JS/CSS module not loading, although I don't get any JS errors in the console.

Other visibly affected stylesheets:

  • oojs-ui dialogs are displaying below the personal bar (T167042)
  • mediawiki.notification popups are ugly
  • jquery.tipsy popups have larger font size than they should
  • jquery.ui buttons are even uglier than usual

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not use ResourceModuleSkinStyles to define skinStyles for other skins than 'minerva'mediawiki/extensions/MobileFrontendwmf/1.30.0-wmf.4+9 -26
Do not use ResourceModuleSkinStyles to define skinStyles for other skins than 'minerva'mediawiki/extensions/MobileFrontendmaster+9 -26
Customize query in gerrit

Related Objects
Search...

Event Timeline

kaldari created this task.Jun 6 2017, 9:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2017, 9:10 PM
kaldari triaged this task as High priority.Jun 6 2017, 9:10 PM
kaldari renamed this task from Preferences page lacking tabs on Test Wikipedia to Preferences page messed up on Test Wikipedia.Jun 6 2017, 9:13 PM
kaldari updated the task description. (Show Details)
kaldari added a subscriber: greg.Jun 6 2017, 9:15 PM

CCing @greg in case this is related to today's train deployment to group 0.

kaldari added a comment.Jun 6 2017, 9:17 PM

Also broken on MediaWiki.org: https://www.mediawiki.org/wiki/Special:Preferences so likely related to the train deployment.

kaldari renamed this task from Preferences page messed up on Test Wikipedia to Preferences page messed up on Test Wikipedia (1.30.0-wmf.4).Jun 6 2017, 9:25 PM
kaldari raised the priority of this task from High to Unbreak Now!.
kaldari added a parent task: T166829: MW-1.30.0-wmf.4 deployment blockers.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 6 2017, 9:27 PM
kaldari added a comment.Jun 6 2017, 9:27 PM

Group 0 was rolled back to wmf.2. The bug can still be seem on the Beta Cluster: https://simple.wikipedia.beta.wmflabs.org/wiki/Special:Preferences

kaldari mentioned this in T167042: [Regression pre-wmf.4] Vector's personal tools are appearing above OOjs UI's global overlay ... again.Jun 6 2017, 9:30 PM
Bawolff subscribed.EditedJun 6 2017, 9:54 PM

That's odd. Looks like the skin specific styles for vector are not loading.

e.g. https://simple.wikipedia.beta.wmflabs.org/w/load.php?debug=true&lang=en&modules=mediawiki.special.preferences.styles&only=styles&skin=vector only loads the generic styles not the vector specific skins/Vector/skinStyles/mediawiki.special.preferences.styles.less. But monobook - https://simple.wikipedia.beta.wmflabs.org/w/load.php?debug=true&lang=en&modules=mediawiki.special.preferences.styles&only=styles&skin=monobook does load skin specific styles. I could not find any recent commits related to that, and was not able to reproduce locally. So i have no idea.

Paladox subscribed.Jun 6 2017, 9:56 PM
kaldari added a project: Vector (legacy skin).Jun 6 2017, 10:02 PM
Jdforrester-WMF subscribed.Jun 6 2017, 11:16 PM
matmarex subscribed.Jun 7 2017, 1:54 PM

I tried a few of the other modules we customized with $wgResourceModuleSkinStyles in Vector, and it seems that none of the customizations are applied. And indeed, other skins are not affected.

matmarex added a comment.Jun 7 2017, 2:29 PM

I have no idea what could be causing this. I read through all the related code (ResourceLoader parts where the customizations are applied, and ExtensionProcessor parts where they are loaded), and compared Vector to MonoBook, and I see no reason for this not to work. I've also checked logstash-beta and there's nothing related in there.

The only vaguely related recent patch is my https://gerrit.wikimedia.org/r/357241 to resolve T167042 – I don't see how that could cause this, either, but unless we have any other ideas, we should try reverting that.

I also can't reproduce this locally. I think at this point someone needs to do some debugging in production (or beta). I don't have access to either.

matmarex added a parent task: T167042: [Regression pre-wmf.4] Vector's personal tools are appearing above OOjs UI's global overlay ... again.Jun 7 2017, 2:31 PM
matmarex renamed this task from Preferences page messed up on Test Wikipedia (1.30.0-wmf.4) to $wgResourceModuleSkinStyles customizations are not being applied for Vector (in Wikimedia production/beta only, 1.30.0-wmf.4).Jun 7 2017, 2:34 PM
matmarex edited projects, added MediaWiki-ResourceLoader; removed MediaWiki-Core-Preferences, JavaScript.
matmarex updated the task description. (Show Details)
matmarex updated the task description. (Show Details)Jun 7 2017, 2:40 PM
matmarex added a comment.Jun 7 2017, 2:52 PM

(offtopic)

The preferences page on Test Wikipedia has no tabs and doesn't have the logo overlay: https://test.wikipedia.org/wiki/Special:Preferences

The logo overlay being missing is expected. The overlay is added in site CSS (https://test.wikipedia.org/wiki/MediaWiki:Vector.css), which is intentionally not loaded on Special:Preferences, Special:UserLogin, etc.

matmarex claimed this task.EditedJun 7 2017, 3:17 PM
matmarex added projects: MobileFrontend, MediaWiki-Configuration.
matmarex added a subscriber: TheDJ.

Inspired by this clever comment by @TheDJ:

[17:05] <thedj> MatmaRex: i've seen something like that before.
[17:05] <thedj> MatmaRex: it happens if someone accidently overrides the array, instead of appending to it

…I decided to grep everything for usages of ResourceModuleSkinStyles. And I found this in MobileFrontend, added in a7a3311bdf313317a7b7bf1597d261e00b570a2d:

	"ResourceModuleSkinStyles": {
		"default": {
			"mobile.special.history.styles": [
				"resources/mobile.special.history.styles/default.less"
			]
		},
		"minerva": {
			"mediawiki.notification": [
				"resources/mobile.startup/toast.less"
			]
		},
		"vector": {
			"mobile.special.mobilemenu.styles": "skinStyles/mobile.special.mobilemenu.styles/vector.less"
		}
	},

It appears that the customization for "vector" overrides the customizations Vector skin itself makes. Possibly this is a bug in ExtensionProcessor?

I'm not sure what this code is supposed to do (both the entries for 'default' and for 'vector' are highly WTF), it should probably be in ResourceModules definitions.

I can confirm that I can reproduce after installing MobileFrontend locally and updating it to master.

gerritbot subscribed.Jun 7 2017, 3:56 PM

Change 357638 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] Do not use ResourceModuleSkinStyles to define skinStyles for other skins than 'minerva'

https://gerrit.wikimedia.org/r/357638

gerritbot added a project: Patch-For-Review.Jun 7 2017, 3:56 PM
matmarex added a subscriber: Legoktm.Jun 7 2017, 4:01 PM

Also clarified documentation: https://www.mediawiki.org/w/index.php?title=Manual:$wgResourceModuleSkinStyles&diff=2484399&oldid=2178078

@Legoktm Should ExtensionProcessor prevent duplicate definitions for ResourceModuleSkinStyles? (That is, throw exceptions if they happen?)

Jdlrobson added projects: Web-Team-Backlog-Archived, Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board-Old.Jun 7 2017, 4:03 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
ovasileva moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog-Archived board.Jun 7 2017, 4:07 PM
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jun 7 2017, 4:17 PM
matmarex renamed this task from $wgResourceModuleSkinStyles customizations are not being applied for Vector (in Wikimedia production/beta only, 1.30.0-wmf.4) to $wgResourceModuleSkinStyles customizations are not being applied for Vector because MobileFrontend accidentally overrides them.Jun 7 2017, 4:21 PM
matmarex removed projects: MediaWiki-Configuration, MediaWiki-ResourceLoader, Vector (legacy skin).
gerritbot added a comment.Jun 7 2017, 4:28 PM

Change 357638 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Do not use ResourceModuleSkinStyles to define skinStyles for other skins than 'minerva'

https://gerrit.wikimedia.org/r/357638

gerritbot added a comment.Jun 7 2017, 4:40 PM

Change 357643 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Do not use ResourceModuleSkinStyles to define skinStyles for other skins than 'minerva'

https://gerrit.wikimedia.org/r/357643

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 7 2017, 5:00 PM
Jdforrester-WMF mentioned this in T167331: ExtensionProcessor should prevent duplicate definitions for ResourceModuleSkinStyles.Jun 7 2017, 5:27 PM
gerritbot added a comment.Jun 7 2017, 8:23 PM

Change 357643 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Do not use ResourceModuleSkinStyles to define skinStyles for other skins than 'minerva'

https://gerrit.wikimedia.org/r/357643

Stashbot subscribed.Jun 7 2017, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2017-06-07T20:26:10Z] <twentyafterfour@tin> Synchronized php-1.30.0-wmf.4/extensions/MobileFrontend: Deploy rEMFR66ef9cbd7f3d refs T167216 (duration: 00m 46s)

• mmodell subscribed.Jun 7 2017, 8:33 PM

Looks like that fixed it.

• mmodell closed this task as Resolved.Jun 7 2017, 8:33 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 7 2017, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits