Server-launched guided tour can show on the wrong page if the user navigates away before full page load
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jun 7 2017, 7:44 AM

Description

The issue is minor - there are two edge cases where guided tours popups are displayed unnecessary:

(1) "Introducing: New Filters for Edit Review (beta)" should be dismissed explicitly

On testwiki, login as a user who does not enable "New filters for edit review" beta feature.
Go to Preferences-Beta and enable "New filters for edit review"
Go to RC page and observe "Introducing: New Filters for Edit Review (beta)" popup - do not click on 'Got it!' or on 'No thanks'.

If you do one of the following

click on Watchlist link (in the navigation menu)
Log out
Log out and then log in again (if the land page is RC)

You will see "Introducing: New Filters for Edit Review (beta)" popup displayed.

Screen Shot 2017-06-07 at 11.29.23 AM.png (481×898 px, 103 KB)

Screen Shot 2017-06-07 at 11.09.17 AM.png (645×1 px, 171 KB)

(2) "New beta feature available for this page" popup appears on the page with already enabled RC filters.

As a user who never enabled "New filters for edit review" beta feature, log in to betalabs.
Go to Beta features and enable "New filters for edit review"
Click on the 'Recent changes' link on the left. On RC page the popup will be displayed.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/WikimediaMessages	wmf/1.30.0-wmf.18	+3 -3	RCFilters tours: Only load on specific page
mediawiki/extensions/GuidedTour	wmf/1.30.0-wmf.18	+296 -132	Allow directly launching tour from server without ?tour= or cookies
mediawiki/extensions/WikimediaMessages	master	+3 -3	RCFilters tours: Only load on specific page
mediawiki/extensions/GuidedTour	master	+296 -132	Allow directly launching tour from server without ?tour= or cookies

Customize query in gerrit

Related Objects

Mentioned In: T169613: Introduce the New Filters to users upon beta graduation
T175765: Move New Filters opt-out preference to its own section on the page
T176191: [betalabs] Watchlist - empty markers displayed for seen/unseen changes
T175880: stickToFirstPage support for server-launched tours (GuidedTourLauncher)
T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis
Collaboration-Team-Triage (Collab-Team-This-Quarter)
T170501: Graduate 'New filters for edit review' out of beta, making it standard on all wikis
Mentioned Here: T169613: Introduce the New Filters to users upon beta graduation
T175765: Move New Filters opt-out preference to its own section on the page
T176191: [betalabs] Watchlist - empty markers displayed for seen/unseen changes
rEGTOfac5ddd92955: Add phpcs and make pass

Event Timeline

Etonkovidova created this task.Jun 7 2017, 7:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2017, 7:44 AM

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jun 13 2017, 8:11 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Etonkovidova updated the task description. (Show Details)Jun 21 2017, 7:30 AM

Etonkovidova updated the task description. (Show Details)Jun 21 2017, 7:44 AM

Can not reproduce.

Please clear all cookies then try again.

If you can still reproduce, let's schedule a meeting to do a screen share.

Etonkovidova updated the task description. (Show Details)Jun 22 2017, 6:23 PM

Etonkovidova updated the task description. (Show Details)Jun 22 2017, 7:30 PM

The issue is reproducible only when the connection is slow, so a user is able to navigate to other pages before the popup is fully loaded. I attached the screen recording to illustrate it.

pop_up_dispalyed_Watchlist.mov3 MBDownload

More screenshots:

Screen Shot 2017-06-22 at 11.22.47 PM.png (562×1 px, 193 KB)

Screen Shot 2017-06-22 at 10.19.25 PM.png (679×1 px, 175 KB)

Okay, I think I know what it is.

I don't think it's a regression (both since I think I identified it, and the only change to the code in wmf/1.30.0-wmf.4 is rEGTOfac5ddd92955: Add phpcs and make pass

I think the user is navigating away before https://phabricator.wikimedia.org/diffusion/EGTO/browse/master/modules/ext.guidedTour.lib/ext.guidedTour.lib.Step.js;94b34bbfd7e9841447b3584c0c481f09b12973d7$641 runs.

This could be fixed by adding showConditionally support to the server (GuidedTourLauncher) with stickToFirstPage.

This should take a Title object as a parameter. Note that the firstSpecialPageName format in the cookie needs to match wgPageName, which is localized and getPrefixedDBKey (Especial:CambiosRecientes). So we should call fixSpecialName. (Or the client-side could canonicalize it, but I think this is easier).

• Mattflaschen-WMF renamed this task from [regression-1.30.0-wmf.4]Persistence of guided tours to Server-launched guided tour can show on the wrong page if the user navigates away before full page load.Jun 22 2017, 10:27 PM

• Mattflaschen-WMF edited projects, added MediaWiki-extensions-GuidedTour, Edit-Review-Improvements-RC-Page; removed Edit-Review-Improvements.

• jmatazzoni mentioned this in T170501: Graduate 'New filters for edit review' out of beta, making it standard on all wikis.Jul 14 2017, 9:50 PM

• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).Jul 17 2017, 8:53 PM

• jmatazzoni mentioned this in T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis.Jul 21 2017, 7:26 PM

@Mooeypoo reports this, or a similar issue, happening today on mw.org

Considering a lot of people are going to see the intro tour upon beta graduation, we may want to prioritize this higher if we have some time.

Change 377915 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/WikimediaMessages@master] [wip] RCFilters tours: Only load on specific page

https://gerrit.wikimedia.org/r/377915

gerritbot added a project: Patch-For-Review.Sep 13 2017, 10:59 PM

Mooeypoo claimed this task.Sep 13 2017, 11:41 PM

Mooeypoo moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

• Mattflaschen-WMF mentioned this in T175880: stickToFirstPage support for server-launched tours (GuidedTourLauncher).Sep 14 2017, 12:24 AM

Change 378827 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/GuidedTour@master] Allow directly launching tour from server without ?tour= or cookies

https://gerrit.wikimedia.org/r/378827

Change 378827 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] Allow directly launching tour from server without ?tour= or cookies

https://gerrit.wikimedia.org/r/378827

Change 377915 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] RCFilters tours: Only load on specific page

https://gerrit.wikimedia.org/r/377915

• Mattflaschen-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Sep 19 2017, 2:00 AM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 19 2017, 2:00 AM

Change 378835 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/GuidedTour@wmf/1.30.0-wmf.18] Allow directly launching tour from server without ?tour= or cookies

https://gerrit.wikimedia.org/r/378835

Change 378836 had a related patch set uploaded (by Mattflaschen; owner: Mooeypoo):
[mediawiki/extensions/WikimediaMessages@wmf/1.30.0-wmf.18] RCFilters tours: Only load on specific page

https://gerrit.wikimedia.org/r/378836

Change 378835 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@wmf/1.30.0-wmf.18] Allow directly launching tour from server without ?tour= or cookies

https://gerrit.wikimedia.org/r/378835

Change 378836 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@wmf/1.30.0-wmf.18] RCFilters tours: Only load on specific page

https://gerrit.wikimedia.org/r/378836

Mentioned in SAL (#wikimedia-operations) [2017-09-19T15:33:35Z] <catrope@tin> Started scap: core, GuidedTour and WikimediaMessages patches for T176191, T167262 and T175765

Stashbot mentioned this in T175765: Move New Filters opt-out preference to its own section on the page.Sep 19 2017, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-19T15:54:08Z] <catrope@tin> Finished scap: core, GuidedTour and WikimediaMessages patches for T176191, T167262 and T175765 (duration: 20m 32s)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)); removed MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 19 2017, 4:00 PM

Etonkovidova mentioned this in T169613: Introduce the New Filters to users upon beta graduation.Sep 20 2017, 1:23 AM

Checked in betalabs along with checking T169613: Introduce the New Filters to users upon beta graduation - the guided tour appears only on the pages that it's supposed to be.

Etonkovidova closed this task as Resolved.Sep 20 2017, 8:03 PM

	F8508159: Screen Shot 2017-06-22 at 10.19.25 PM.png
	Jun 22 2017, 7:37 PM

	F8508149: pop_up_dispalyed_Watchlist.mov
	Jun 22 2017, 7:37 PM

	F8508154: Screen Shot 2017-06-22 at 11.22.47 PM.png
	Jun 22 2017, 7:37 PM

	F8396270: Screen Shot 2017-06-07 at 11.09.17 AM.png
	Jun 7 2017, 7:44 AM

	F8396281: Screen Shot 2017-06-07 at 10.22.00 AM.png
	Jun 7 2017, 7:44 AM

	F8396268: Screen Shot 2017-06-07 at 11.29.23 AM.png
	Jun 7 2017, 7:44 AM

Server-launched guided tour can show on the wrong page if the user navigates away before full page loadClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Server-launched guided tour can show on the wrong page if the user navigates away before full page load
Closed, ResolvedPublic
Actions