Page MenuHomePhabricator
Create Task
Maniphest T167301

The new crossproject search results sidebar does not work on non-wikipedias
Closed, ResolvedPublic
Actions

Description

There is a display issue:

Risultati della ricerca di "~test" - Wikisource - Google Chrome_008.png (1×1 px, 222 KB)

and a php stacktrace:

/srv/mediawiki/php-1.30.0-wmf.2/includes/widget/search/InterwikiSearchResultSetWidget.php:180
PHP Notice: Undefined index: port
#0 /srv/mediawiki/php-1.30.0-wmf.2/includes/widget/search/InterwikiSearchResultSetWidget.php(180): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.30.0-wmf.2/includes/widget/search/InterwikiSearchResultSetWidget.php(145): MediaWiki\Widget\Search\InterwikiSearchResultSetWidget->iwIcon(string)
#2 /srv/mediawiki/php-1.30.0-wmf.2/includes/widget/search/InterwikiSearchResultSetWidget.php(89): MediaWiki\Widget\Search\InterwikiSearchResultSetWidget->footerHtml(string, string)
#3 /srv/mediawiki/php-1.30.0-wmf.2/includes/widget/search/BasicSearchResultSetWidget.php(93): MediaWiki\Widget\Search\InterwikiSearchResultSetWidget->render(string, array)
#4 /srv/mediawiki/php-1.30.0-wmf.2/includes/specials/SpecialSearch.php(425): MediaWiki\Widget\Search\BasicSearchResultSetWidget->render(string, integer, NULL, CirrusSearch\Search\ResultSet)
#5 /srv/mediawiki/php-1.30.0-wmf.2/includes/specials/SpecialSearch.php(185): SpecialSearch->showResults(string)
#6 /srv/mediawiki/php-1.30.0-wmf.2/includes/specialpage/SpecialPage.php(522): SpecialSearch->execute(NULL)
#7 /srv/mediawiki/php-1.30.0-wmf.2/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.30.0-wmf.2/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.30.0-wmf.2/includes/MediaWiki.php(862): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.30.0-wmf.2/includes/MediaWiki.php(523): MediaWiki->main()
#11 /srv/mediawiki/php-1.30.0-wmf.2/index.php(43): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fixing display issue with interwiki search sidebarmediawiki/coremaster+1 -1
Properly check that the port key is presentmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

dcausse created this task.Jun 7 2017, 2:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2017, 2:24 PM
gerritbot subscribed.Jun 7 2017, 3:29 PM

Change 357628 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/core@master] Fixing display issue with interwiki search sidebar

https://gerrit.wikimedia.org/r/357628

gerritbot added a project: Patch-For-Review.Jun 7 2017, 3:29 PM
Jdrewniak subscribed.Jun 7 2017, 3:31 PM

I think this was a CSS issue due to me using display:inline-block to vertically position the top of the sidebar with the top of the search results. Reducing the margin from 10% to 8% seems to fix it.

Screen Shot 2017-06-07 at 4.22.37 PM.png (879×1 px, 577 KB)

• debt triaged this task as High priority.Jun 7 2017, 3:40 PM
• debt edited projects, added Discovery-Search (Current work), Discovery-ARCHIVED; removed Discovery-Search.
• debt moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
• debt added a parent task: T162626: turn on sister project snippets in search results page on all Wikipedias.
gerritbot added a comment.Jun 7 2017, 4:48 PM

Change 357647 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/core@master] Properly check that the port key is present

https://gerrit.wikimedia.org/r/357647

Jdrewniak added a comment.Jun 8 2017, 10:05 AM

Also, the reason this was breaking no wikisource specifically, and not wikipedia,
was that someone somewhere added a CSS class that adds extra margins to all the <ul>'s on the site.

Screen Shot 2017-06-08 at 12.02.57 PM.png (1×1 px, 1 MB)

gerritbot added a comment.Jun 8 2017, 10:15 AM

Change 357647 merged by jenkins-bot:
[mediawiki/core@master] Properly check that the port key is present

https://gerrit.wikimedia.org/r/357647

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 11:00 AM
gerritbot added a comment.Jun 8 2017, 2:27 PM

Change 357628 merged by jenkins-bot:
[mediawiki/core@master] Fixing display issue with interwiki search sidebar

https://gerrit.wikimedia.org/r/357628

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 3:00 PM
• debt moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jun 13 2017, 5:19 PM
• debt closed this task as Resolved.Jun 16 2017, 5:24 PM
• debt claimed this task.
• debt removed • debt as the assignee of this task.Jun 19 2017, 6:21 PM
• debt subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits