Page MenuHomePhabricator

Undo trunking to virts for a sane flat networking model
Closed, ResolvedPublic

Description

We currently have a trunk established to all labvirts. This trunk allows both the labs-hosts and labs-instances VLAN in eqiad, and the labs-instances VLAN in labtest (codfw). The most probable origin is labvirt's originally had a single interface connected and sub-interfaces for managment and instance traffic.

We cannot make use of the trunking due to our current tpology:

nova.conf

network_manager=nova.network.manager.FlatDHCPManager

But it adds complexity, and complicates testing.

Puppet config related:

hieradata/common.yaml:  network_flat_interface: 'eth1.1102'
hieradata/common.yaml:  network_flat_tagged_base_interface: 'eth1'
hieradata/common.yaml:  network_flat_interface_vlan: '1102'

interface/manifests/tagged.pp:    require_package('vlan')

    interface::tagged { $novaconfig['network_flat_interface']:
        base_interface => $novaconfig['network_flat_tagged_base_interface'],
        vlan_id        => $novaconfig['network_flat_interface_vlan'],
        method         => 'manual',
        up             => 'ip link set $IFACE up',
        down           => 'ip link set $IFACE down',
    }

modules/openstack/templates/liberty/nova/nova.conf.erb:flat_interface=<%= @novaconfig["network_flat_interface"] %>
modules/role/manifests/labs/openstack/nova/compute.pp:    interface::tagged { $novaconfig['network_flat_interface']:
modules/role/manifests/labs/openstack/nova/compute.pp:        vlan_id        => $novaconfig['network_flat_interface_vlan'],
modules/role/manifests/labs/openstack/nova/network.pp:    interface::tagged { $novaconfig['network_flat_interface']:
modules/role/manifests/labs/openstack/nova/network.pp:        vlan_id        => $novaconfig['network_flat_interface_vlan'],

modules/role/manifests/labs/openstack/nova/compute.pp:        base_interface => $novaconfig['network_flat_tagged_base_interface'],
modules/role/manifests/labs/openstack/nova/network.pp:        base_interface => $novaconfig['network_flat_tagged_base_interface'],

modules/role/manifests/labs/openstack/nova/compute.pp:        vlan_id        => $novaconfig['network_flat_interface_vlan'],
modules/role/manifests/labs/openstack/nova/network.pp:        vlan_id        => $novaconfig['network_flat_interface_vlan'],

Event Timeline

chasemp claimed this task.

Well, we are getting scarce on interfaces and for the most part throughput is not an issue where we are testing so I'm tentatively closing this (for now) as we are going to keep using subinterfaces for awhile.