⚓ T167359 Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given

Project	Branch	Lines +/-	Subject
mediawiki/extensions/RevisionSlider	wmf/1.30.0-wmf.4	+1 -1	Also drop Revision typehint from $oldRev
mediawiki/extensions/RevisionSlider	master	+1 -1	Also drop Revision typehint from $oldRev
mediawiki/extensions/RevisionSlider	wmf/1.30.0-wmf.4	+6 -5	Handle possible null $oldRev in DiffViewHeader hook handler
mediawiki/extensions/RevisionSlider	master	+6 -5	Handle possible null $oldRev in DiffViewHeader hook handler

		Status	Subtype	Assigned	Task
		Resolved		demon	T166829 MW-1.30.0-wmf.4 deployment blockers
		Resolved	PRODUCTION ERROR	demon	T167359 Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given

mmodell created this task.Jun 7 2017, 9:38 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJun 7 2017, 9:38 PM

mmodell raised the priority of this task from Medium to High.Jun 7 2017, 9:43 PM

If blocking the train, UBN!

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 7 2017, 11:38 PM

Change 357748 had a related patch set uploaded (by Aude; owner: Aude):
[mediawiki/extensions/RevisionSlider@master] Handle possible null $oldRev in DiffViewHeader hook handler

https://gerrit.wikimedia.org/r/357748

gerritbot added a project: Patch-For-Review.Jun 8 2017, 2:28 AM

aude mentioned this in rERSL71c586a351b0: Handle possible null $oldRev in DiffViewHeader hook handler.Jun 8 2017, 2:30 AM

Change 357748 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Handle possible null $oldRev in DiffViewHeader hook handler

https://gerrit.wikimedia.org/r/357748

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 11:00 AM

Liuxinyu970226 added a subscriber: Liuxinyu970226.Jun 8 2017, 12:58 PM

Change 357802 had a related patch set uploaded (by Aude; owner: Aude):
[mediawiki/extensions/RevisionSlider@wmf/1.30.0-wmf.4] Handle possible null $oldRev in DiffViewHeader hook handler

https://gerrit.wikimedia.org/r/357802

aude mentioned this in rERSL80c3329a7ecf: Handle possible null $oldRev in DiffViewHeader hook handler.Jun 8 2017, 1:15 PM

Change 357802 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@wmf/1.30.0-wmf.4] Handle possible null $oldRev in DiffViewHeader hook handler

https://gerrit.wikimedia.org/r/357802

Mentioned in SAL (#wikimedia-operations) [2017-06-08T13:47:25Z] <aude@tin> Synchronized php-1.30.0-wmf.4/extensions/RevisionSlider: Fix fatal error: T167359 (duration: 00m 44s)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 2:00 PM

Is this Resolved?

I'm still seeing this in production.

The fix above ^ won't fix this at all. The error is that the function is being *passed* a null value, not that a null value is being *used*

What you need to do here is adjust the function signature. Either drop the Revision type hints or set it to default null (Revision $r = null) to also allow null values.

On re-reading the patch, it looks like $newRev does this, $oldRev still doesn't. I'll get a patch up.

Change 357945 had a related patch set uploaded (by Chad; owner: Chad):
[mediawiki/extensions/RevisionSlider@master] Also drop Revision typehint from $oldRev

https://gerrit.wikimedia.org/r/357945

Change 357945 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Also drop Revision typehint from $oldRev

https://gerrit.wikimedia.org/r/357945

demon mentioned this in rERSL0687de3fbdc3: Also drop Revision typehint from $oldRev.Jun 8 2017, 10:35 PM

Change 357946 had a related patch set uploaded (by Chad; owner: Chad):
[mediawiki/extensions/RevisionSlider@wmf/1.30.0-wmf.4] Also drop Revision typehint from $oldRev

https://gerrit.wikimedia.org/r/357946

Change 357946 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@wmf/1.30.0-wmf.4] Also drop Revision typehint from $oldRev

https://gerrit.wikimedia.org/r/357946

demon mentioned this in rERSL319e382d41f0: Also drop Revision typehint from $oldRev.Jun 8 2017, 10:40 PM

Now it's fixed.

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 8 2017, 10:57 PM

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)); removed MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 8 2017, 11:00 PM

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jun 10 2017, 5:20 AM

• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:45 PM

Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Oct 10 2017, 9:39 AM

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:05 PM

Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Details

Related Objects
Search...

Event Timeline

Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given Closed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related ObjectsSearch...

Event Timeline

Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Related Objects
Search...