Regression: Main menu unstyled without JS.
Closed, ResolvedPublic
Actions

Description

The module skins.minerva.mainMenu.styles is no longer being added to the page as a stylesheet.
The module skins.minerva.mainMenu.icons is also added via JS.

Expected:

Styles should be loaded via addModuleStyles inside onSpecialPageBeforeExecute

Details

Related Gerrit Patches:

mediawiki/extensions/MobileFrontend : wmf/1.30.0-wmf.4	Add styles to Special:MobileMenu
mediawiki/extensions/MobileFrontend : master	Add styles to Special:MobileMenu

Related Objects

Mentioned Here: rEMFRa7a3311bdf31: MainMenu belongs to Minerva not MobileFrontend

Event Timeline

Jdlrobson created this task.Jun 8 2017, 12:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 12:25 AM

Jdlrobson renamed this task from Main menu unstyled without JS. to Regression: Main menu unstyled without JS..Jun 8 2017, 12:25 AM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

ovasileva triaged this task as High priority.Jun 8 2017, 12:06 PM

ovasileva moved this task from Incoming to 2016-17 Q4 on the Readers-Web-Backlog board.Jun 8 2017, 12:14 PM

This regression was introduced in rEMFRa7a3311bdf31: MainMenu belongs to Minerva not MobileFrontend, which will be riding the train when it resumes.

bmansurov claimed this task.Jun 8 2017, 3:20 PM

bmansurov moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 357830 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/extensions/MobileFrontend@master] Add styles to Special:MobileMenu

https://gerrit.wikimedia.org/r/357830

gerritbot added a project: Patch-For-Review.Jun 8 2017, 3:27 PM

bmansurov moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 8 2017, 3:27 PM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jun 8 2017, 3:51 PM

bmansurov removed bmansurov as the assignee of this task.Jun 8 2017, 3:59 PM

bmansurov added a subscriber: bmansurov.

Change 357830 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add styles to Special:MobileMenu

https://gerrit.wikimedia.org/r/357830

Change 357846 had a related patch set uploaded (by Jdlrobson; owner: Bmansurov):
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Add styles to Special:MobileMenu

https://gerrit.wikimedia.org/r/357846

Since this impacts all grade C browsers and I'm SWATing anyway, I will get this deployed today at 4pm PST.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 5:00 PM

Agreed. It'll roll out to group1 wikis during today's MediaWiki train deployment.

Change 357846 merged by MaxSem:
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Add styles to Special:MobileMenu

https://gerrit.wikimedia.org/r/357846

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 7:00 PM