Fix peeking on images with capitalized extension - i.e. ".JPG"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Jun 8 2017, 12:33 AM

Description

Noticed when peeking first non-lead image on enwiki > Freestyle swimming - was peeking the image's file page instead of the gallery.

Mentioned In: rAPIOS8758c8f0877d: Merge pull request #1517 from wikimedia/bug/image-peek-extension-case/T167371
rAPIOS0ce2ebc1c33f: Merge branch 'develop' into bug/image-peek-extension-case/T167371

Testing criteria

on 3D-touch capable device
load enwiki > Freestyle swimming
scroll down a bit to first image after the lead image
try to peek the image
the peek should present the image in the gallery view (with a black background) rather than loading the file page for the image

See the PR for animations.

Testing on iPhone 6s (iOS 10.3.2) and iPhone 7 (iOS 10.3.1). I'm not sure this is fixed as white backgrounds are showing on both devices.

• JMinor triaged this task as Low priority.Jun 12 2017, 6:39 PM

May not have been in build. Please retest with 1150

Tested on iPhone 7+ with iOS 10.3.2 on 10.2.1 on App version 5.5.0 (1150)

Fixed!

	F8414648: T167371 iPhone 6s (iOS 10.3.2).PNG
	Jun 8 2017, 8:25 PM

	F8414649: T167371 iPhone 7 (iOS 10.3.1).PNG
	Jun 8 2017, 8:25 PM