Page MenuHomePhabricator
Create Task
Maniphest T167390

IDs for buttons on edit page changed in non-OOUI mode
Closed, ResolvedPublic
Actions

Description

T165854: Change OOUI EditPage inputs to keep the old 'id' attributes on the <input> elements wanted to make sure that the ids stay the same in OOUI mode, but it seems that some of the wrapper ids leaked into non-OOUI mode, breaking scripts in the same way as it was meant to prevent.

On https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Benutzer:Schnark&action=submit (still non-OOUI mode) I have <input id="wpSaveWidget" inputid="wpSave"> and similar for the two other buttons. Summary input and checkboxes have the correct ids.

Details

SubjectRepoBranchLines +/-
EditPage: Fix 'id' attributes on buttons in non-OOUI modemediawiki/corewmf/1.30.0-wmf.4+9 -9
EditPage: Fix 'id' attributes on buttons in non-OOUI modemediawiki/coremaster+9 -9
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Jun 8 2017, 9:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 9:39 AM
matmarex claimed this task.Jun 8 2017, 4:56 PM

Oh noooooo D:

gerritbot subscribed.Jun 8 2017, 5:12 PM

Change 357852 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357852

gerritbot added a project: Patch-For-Review.Jun 8 2017, 5:12 PM
• Deskana triaged this task as Unbreak Now! priority.Jun 8 2017, 5:20 PM
• Deskana subscribed.

This needs fixing quickly.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 8 2017, 5:20 PM
gerritbot added a comment.Jun 8 2017, 5:30 PM

Change 357852 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357852

gerritbot added a comment.Jun 8 2017, 5:31 PM

Change 357855 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.30.0-wmf.4] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357855

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jun 8 2017, 6:00 PM
gerritbot added a comment.Jun 8 2017, 6:31 PM

Change 357855 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.4] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357855

matmarex closed this task as Resolved.Jun 8 2017, 6:38 PM
matmarex removed a project: Patch-For-Review.

Fixed and deployed. Thank you for reporting this @Schnark!

(wmf.4 is currently only live at testwiki, but it will hopefully finally go out to all wikis later today.)

Jdforrester-WMF added a project: Editing-team.Jun 8 2017, 6:46 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes.Jun 8 2017, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL