Page MenuHomePhabricator

IDs for buttons on edit page changed in non-OOUI mode
Closed, ResolvedPublic

Description

T165854: Change OOUI EditPage inputs to keep the old 'id' attributes on the <input> elements wanted to make sure that the ids stay the same in OOUI mode, but it seems that some of the wrapper ids leaked into non-OOUI mode, breaking scripts in the same way as it was meant to prevent.

On https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Benutzer:Schnark&action=submit (still non-OOUI mode) I have <input id="wpSaveWidget" inputid="wpSave"> and similar for the two other buttons. Summary input and checkboxes have the correct ids.

Event Timeline

Schnark created this task.Jun 8 2017, 9:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 9:39 AM
matmarex claimed this task.Jun 8 2017, 4:56 PM

Oh noooooo D:

Change 357852 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357852

Deskana triaged this task as Unbreak Now! priority.Jun 8 2017, 5:20 PM
Deskana added a subscriber: Deskana.

This needs fixing quickly.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 8 2017, 5:20 PM

Change 357852 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357852

Change 357855 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.30.0-wmf.4] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357855

Change 357855 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.4] EditPage: Fix 'id' attributes on buttons in non-OOUI mode

https://gerrit.wikimedia.org/r/357855

matmarex closed this task as Resolved.Jun 8 2017, 6:38 PM
matmarex removed a project: Patch-For-Review.

Fixed and deployed. Thank you for reporting this @Schnark!

(wmf.4 is currently only live at testwiki, but it will hopefully finally go out to all wikis later today.)