Page MenuHomePhabricator
Create Task
Maniphest T167461

SpecialMobileDiff: Call to member function getDiffBody() on non-object
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production:

[WTmllQpAMFEAAEiQc2UAAAAT] /wiki/Special:MobileDiff/57276328   BadMethodCallException from line 266 of /srv/mediawiki/php-1.30.0-wmf.4/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php: Call to a member function getDiffBody() on a non-object (null)

https://logstash.wikimedia.org/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-7d,mode:quick,to:now))&_a=(columns:!(_source),index:'logstash-*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'message:%22getDiffBody%22')),sort:!('@timestamp',desc))

The error occurs here:

Details

SubjectRepoBranchLines +/-
Ensure mDiffEngine is always availablemediawiki/extensions/MobileFrontendwmf/1.30.0-wmf.4+19 -16
Ensure mDiffEngine is always availablemediawiki/extensions/MobileFrontendmaster+19 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

• demon created this task.Jun 8 2017, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 7:45 PM
Framawiki added a project: MobileFrontend.Jun 8 2017, 7:47 PM
Jdlrobson raised the priority of this task from Medium to High.Jun 8 2017, 8:36 PM
Jdlrobson added projects: Web-Team-Backlog, Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board-Old.
Jdlrobson subscribed.

This appears to be blocking deployment?

Jdlrobson moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog board.Jun 8 2017, 8:37 PM
Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a comment.Jun 8 2017, 8:43 PM

Probably caused by https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/98c2116143d79048c243303cd0adcf931f0b73f5

Jdlrobson updated the task description. (Show Details)Jun 8 2017, 8:45 PM
gerritbot subscribed.Jun 8 2017, 9:03 PM

Change 357918 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Ensure mDiffEngine is available inside showDiff

https://gerrit.wikimedia.org/r/357918

gerritbot added a project: Patch-For-Review.Jun 8 2017, 9:03 PM
• demon added a comment.Jun 8 2017, 9:05 PM
In T167461#3334026, @Jdlrobson wrote:

This appears to be blocking deployment?

Not blocking really, it's not super common from what I can tell. But thanks for getting a quick fix up!

Jdlrobson updated the task description. (Show Details)Jun 8 2017, 9:05 PM
Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
pmiazga removed a project: Patch-For-Review.Jun 8 2017, 9:38 PM
pmiazga moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson added a comment.Jun 8 2017, 9:43 PM

@demon need me to swat this to wmf4? Seems to impact all diff pages on mobile wikidata...!

gerritbot added a comment.Jun 8 2017, 9:47 PM

Change 357918 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Ensure mDiffEngine is always available

https://gerrit.wikimedia.org/r/357918

gerritbot added a comment.Jun 8 2017, 9:57 PM

Change 357942 had a related patch set uploaded (by Chad; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Ensure mDiffEngine is always available

https://gerrit.wikimedia.org/r/357942

gerritbot added a project: Patch-For-Review.Jun 8 2017, 9:57 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 10:00 PM
gerritbot added a comment.Jun 8 2017, 10:14 PM

Change 357942 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Ensure mDiffEngine is always available

https://gerrit.wikimedia.org/r/357942

Jdforrester-WMF subscribed.Jun 8 2017, 10:17 PM

Should this be back-ported or removed as a blocker to deployment?

• demon closed this task as Resolved.Jun 8 2017, 10:18 PM
• demon claimed this task.

Was backported and is now fixed.

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 8 2017, 10:18 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 11:00 PM
• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:45 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL