Page MenuHomePhabricator

SpecialMobileDiff: Call to member function getDiffBody() on non-object
Closed, ResolvedPublic

Description

Spotted in production:

[WTmllQpAMFEAAEiQc2UAAAAT] /wiki/Special:MobileDiff/57276328   BadMethodCallException from line 266 of /srv/mediawiki/php-1.30.0-wmf.4/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php: Call to a member function getDiffBody() on a non-object (null)

https://logstash.wikimedia.org/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-7d,mode:quick,to:now))&_a=(columns:!(_source),index:'logstash-*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'message:%22getDiffBody%22')),sort:!('@timestamp',desc))

The error occurs here:

Event Timeline

demon created this task.Jun 8 2017, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 7:45 PM
Jdlrobson raised the priority of this task from Normal to High.Jun 8 2017, 8:36 PM
Jdlrobson added a subscriber: Jdlrobson.

This appears to be blocking deployment?

Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Jun 8 2017, 8:45 PM

Change 357918 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Ensure mDiffEngine is available inside showDiff

https://gerrit.wikimedia.org/r/357918

demon added a comment.Jun 8 2017, 9:05 PM

This appears to be blocking deployment?

Not blocking really, it's not super common from what I can tell. But thanks for getting a quick fix up!

@demon need me to swat this to wmf4? Seems to impact all diff pages on mobile wikidata...!

Change 357918 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Ensure mDiffEngine is always available

https://gerrit.wikimedia.org/r/357918

Change 357942 had a related patch set uploaded (by Chad; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Ensure mDiffEngine is always available

https://gerrit.wikimedia.org/r/357942

Change 357942 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.30.0-wmf.4] Ensure mDiffEngine is always available

https://gerrit.wikimedia.org/r/357942

Should this be back-ported or removed as a blocker to deployment?

demon closed this task as Resolved.Jun 8 2017, 10:18 PM
demon claimed this task.

Was backported and is now fixed.

mmodell changed the subtype of this task from "Task" to "Production Error".Wed, Aug 28, 11:10 PM