Page MenuHomePhabricator

Deprecate $wgExperimentalHtmlIds
Closed, ResolvedPublic2 Estimated Story Points

Description

In preparation for T152540, we should remove old code related to $wgExperimentalHtmlIds. This global variable has been turned off for all Wikimedia projects since 2011. The only code we should leave for now is the variable initialization in DefaultSettings.php, which should be marked as deprecated. We should also mark the variable as deprecated at https://www.mediawiki.org/wiki/Manual:$wgExperimentalHtmlIds.

Places this variable is mentioned or used:

  • includes/api/ApiMain.php
  • includes/parser/Parser.php
  • includes/Sanitizer.php
  • tests/parser/ParserTestRunner.php
  • tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
  • lib/wt2html/tt/Sanitizer.js in parsoid

Event Timeline

Change 357962 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] WIP: deprecate $wgExperimentalHtmlIds

https://gerrit.wikimedia.org/r/357962

Not merging yet, but I consider this done.

kaldari triaged this task as Medium priority.Jun 13 2017, 4:31 AM
kaldari set the point value for this task to 2.
kaldari removed a project: Community-Tech.
kaldari moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
Legoktm added a subscriber: Legoktm.

Until it's merged, the bug shouldn't be closed.

Change 357962 abandoned by MaxSem:
Deprecate $wgExperimentalHtmlIds

https://gerrit.wikimedia.org/r/357962

@MaxSem: Do you have a new patch for this?

Done as part of the main commit https://gerrit.wikimedia.org/r/#/c/362326/
Not sure if this bug needs to be kept open if we're not doing anything separate on it now.