Page MenuHomePhabricator
Create Task
Maniphest T167470

Deprecate $wgExperimentalHtmlIds
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

In preparation for T152540, we should remove old code related to $wgExperimentalHtmlIds. This global variable has been turned off for all Wikimedia projects since 2011. The only code we should leave for now is the variable initialization in DefaultSettings.php, which should be marked as deprecated. We should also mark the variable as deprecated at https://www.mediawiki.org/wiki/Manual:$wgExperimentalHtmlIds.

Places this variable is mentioned or used:

  • includes/api/ApiMain.php
  • includes/parser/Parser.php
  • includes/Sanitizer.php
  • tests/parser/ParserTestRunner.php
  • tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
  • lib/wt2html/tt/Sanitizer.js in parsoid

Details

SubjectRepoBranchLines +/-
Deprecate $wgExperimentalHtmlIdsmediawiki/coremaster+14 -83
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Jun 8 2017, 8:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 8:59 PM
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jun 8 2017, 9:00 PM
kaldari added a subscriber: MaxSem.
MaxSem claimed this task.Jun 8 2017, 9:07 PM
MaxSem added a project: Community-Tech-Sprint.
MaxSem mentioned this in T29733: Sanitizer strips more underscores from id's in $wgExperimentalHtmlIds mode.Jun 9 2017, 1:25 AM
gerritbot subscribed.Jun 9 2017, 1:32 AM

Change 357962 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] WIP: deprecate $wgExperimentalHtmlIds

https://gerrit.wikimedia.org/r/357962

gerritbot added a project: Patch-For-Review.Jun 9 2017, 1:32 AM
MaxSem moved this task from Ready to In Development on the Community-Tech-Sprint board.Jun 9 2017, 1:43 AM
Aklapper added a project: Technical-Debt.Jun 9 2017, 7:50 AM
MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jun 9 2017, 6:08 PM
kaldari closed this task as Resolved.Jun 13 2017, 4:30 AM

Not merging yet, but I consider this done.

kaldari triaged this task as Medium priority.Jun 13 2017, 4:31 AM
kaldari set the point value for this task to 2.
kaldari removed a project: Community-Tech.
kaldari moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
Legoktm reopened this task as Open.Jun 13 2017, 5:35 AM
Legoktm subscribed.

Until it's merged, the bug shouldn't be closed.

gerritbot added a comment.Jun 14 2017, 8:05 PM

Change 357962 abandoned by MaxSem:
Deprecate $wgExperimentalHtmlIds

https://gerrit.wikimedia.org/r/357962

kaldari moved this task from Q1 2018-19 to In Development on the Community-Tech-Sprint board.Jun 14 2017, 9:30 PM
MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jul 10 2017, 10:26 PM
kaldari added a comment.Jul 10 2017, 11:45 PM

@MaxSem: Do you have a new patch for this?

MaxSem added a comment.Jul 10 2017, 11:47 PM

Done as part of the main commit https://gerrit.wikimedia.org/r/#/c/362326/
Not sure if this bug needs to be kept open if we're not doing anything separate on it now.

MaxSem closed this task as Resolved.Aug 4 2017, 11:39 PM
MaxSem moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Aug 17 2017, 10:38 PM
• DannyH moved this task from Needs Discussion to Archive on the Community-Tech board.Aug 17 2017, 10:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL