[Regression wmf.4] Dialog footer broken for templates
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Jun 9 2017, 12:50 AM

Description

Details

	Subject	Repo	Branch	Lines +/-
	Revert 032fb292, a97eacd0	mediawiki/extensions/VisualEditor	master	+4 -4
	MWTransclusionDialog: size footer correctly	mediawiki/extensions/VisualEditor	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T93290: ButtonElements with no label, icon and indicator should still have consistent height
Mentioned Here: rEVED032fb2924e14: MWTransclusionDialog: size footer correctly
rEVEDa97eacd05b17: Remove dialog height hack tagged against resolved bug
T93290: ButtonElements with no label, icon and indicator should still have consistent height
T167710: [Regression wmf.4] "Show options" button is disabled in the template dialog while trying to re-edit it

Event Timeline

Esanders created this task.Jun 9 2017, 12:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2017, 12:50 AM

matmarex merged a task: T167707: [Regression ?] Show options/ Hide options button in the template dialog is appearing beyond the dialog footer area.Jun 12 2017, 5:47 PM

matmarex added subscribers: Ryasmeen, • Deskana, Jdforrester-WMF.

• Deskana triaged this task as High priority.Jun 12 2017, 6:10 PM

• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Probably also caused T167710: [Regression wmf.4] "Show options" button is disabled in the template dialog while trying to re-edit it (or at least related).

Change 358632 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWTransclusionDialog: size footer correctly

https://gerrit.wikimedia.org/r/358632

gerritbot added a project: Patch-For-Review.Jun 13 2017, 4:49 PM

Change 358632 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWTransclusionDialog: size footer correctly

https://gerrit.wikimedia.org/r/358632

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)).Jun 14 2017, 12:00 PM

Ryasmeen closed this task as Resolved.Jun 14 2017, 1:48 PM

Ryasmeen edited projects, added Verified; removed Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 14 2017, 1:48 PM

Ryasmeen assigned this task to DLynch.Jun 14 2017, 1:48 PM

In T167483#3342024, @Jdforrester-WMF wrote:

Probably also caused T167710: [Regression wmf.4] "Show options" button is disabled in the template dialog while trying to re-edit it (or at least related).

Just checked, T167710 still exists.

This was caused by rEVEDa97eacd05b17: Remove dialog height hack tagged against resolved bug. Clearly, T93290 is not really fixed.

matmarex mentioned this in T93290: ButtonElements with no label, icon and indicator should still have consistent height.Jun 14 2017, 6:40 PM

Change 359010 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Revert 032fb292, a97eacd0

https://gerrit.wikimedia.org/r/359010

gerritbot added a project: Patch-For-Review.Jun 14 2017, 6:40 PM

Change 359010 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Revert 032fb292, a97eacd0