Page MenuHomePhabricator

"From date" on Special:Contributions doesn't filter Flow edits
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Open Special:Contributions on a wiki that uses Flow.
  2. Filter for a date range. Example result URL: https://www.mediawiki.org/w/index.php?title=Special:Contributions&target=Tacsipacsi&start=2017-05-28&end=2017-06-03

Actual result

  1. Notice that all edits in the specified date range appear, plus any Flow edits before and after.

Expected result

  1. Notice that only edits in the specified date range appear, including Flow edits in that range, but excluding older and newer Flow edits.

Screen Shot 2017-06-10 at 16.13.21.png (1×2 px, 477 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Trizek-WMF subscribed.

That's related to the fact that Flow posts are not indexed in search. Yet.

matmarex subscribed.

I don't think this is related to search. As far as I know, date range filtering previously worked on Special:Contributions for Flow edits (back when it was done using the year+month inputs).

Also, the "To date" option seems to work correctly, only "From date" is not respected. For example: https://www.mediawiki.org/w/index.php?title=Special:Contributions&target=Quiddity_(WMF)&start=2017-05-28&end=2017-06-03

www.mediawiki.org-w-index.php-title=Special-Contributions&target=Quiddity_(WMF)&start=2017-05-28&end=2017-06-03(Laptop with HiDPI screen).png (1×1 px, 493 KB)

(Quiddity made a few Flow edits after the "to date", on 5 June and they are correctly not shown. However, we see Flow edits from before the "start date", e.g. from 21 May.)

Since the option to specify a start date is newly added in b66888733c182fd02478c0d351682b15c3f114df (which also changed the year+month input into a single date input), I think Flow needs to be updated to support it. This is separate from the search functionality.

matmarex renamed this task from date picker doesn't filter Flow contributions to "From date" on Special:Contributions doesn't filter Flow edits.Jun 12 2017, 10:18 PM
matmarex removed a project: OOUI.

It does not seem to be specific to Flow. As far as I could see there are two issues
(1) When there are no results within the data range, the query falls on the closest available results (?)

(2) When options 'latest' or 'View (older 50) are clicked, the date selection will be discarded. The url might look like: https://commons.wikimedia.org/w/index.php?title=Special:Contributions&dir=prev&contribs=user&target=Yann&namespace=&tagfilter=&start=2017-06-05&end=2017-06-05 , but the result set from 2004 year.

Note: another problem is that result of selecting options for 'latest', 'oldest', etc is confusing and  what options were actually selected are not clearly visible to a user.

Some examples:

  • There are no results found for June 13, 2017, so the results from June 5, 2017 are displayed.
    Screen Shot 2017-06-13 at 2.33.31 PM.png (582×1 px, 226 KB)
  • the same user as in the reported issue. The user does not have results for the selected date range (May 15, 2017), so the results from 2015 are returned.

Screen Shot 2017-06-13 at 2.16.54 PM.png (489×821 px, 95 KB)

CORRECT cases (the user is the same as in the reported issue):

  • surprisingly, if the date range includes June 08, 2017, the returned results display dates such as June 06-07, 2017 which makes the previous case (when the results from 2015 are displayed for June 08, 2017) even more puzzling.

Screen Shot 2017-06-13 at 2.14.08 PM.png (569×840 px, 139 KB)

  • selected date range works:

Screen Shot 2017-06-13 at 2.10.10 PM.png (631×1 px, 214 KB)

  • one-day selection works too

Screen Shot 2017-06-13 at 2.12.11 PM.png (571×784 px, 146 KB)

I don't think this is related to search. As far as I know, date range filtering previously worked on Special:Contributions for Flow edits (back when it was done using the year+month inputs).

My bad, sorry. :/

Tacsipacsi updated the task description. (Show Details)
Tacsipacsi changed the subtype of this task from "Task" to "Bug Report".
Tacsipacsi added subscribers: geraki, alaa, Dalba, Framawiki.
Tacsipacsi subscribed.

In the meantime, both Flow edits before and after the specified date range appear, which also means that if one has a sufficiently large number of Flow edits after the date range, it’s quite difficult to find the interesting edits. Description updated to actually contain the bug report. (The example I included in the description currently shows the two interesting edits as 495th and 496th, so they may not be on the first page even with the largest 500-edit limit in a few days.)

It does not seem to be specific to Flow. As far as I could see there are two issues
(1) When there are no results within the data range, the query falls on the closest available results (?)

(2) When options 'latest' or 'View (older 50) are clicked, the date selection will be discarded. The url might look like: https://commons.wikimedia.org/w/index.php?title=Special:Contributions&dir=prev&contribs=user&target=Yann&namespace=&tagfilter=&start=2017-06-05&end=2017-06-05 , but the result set from 2004 year.

Note: another problem is that result of selecting options for 'latest', 'oldest', etc is confusing and  what options were actually selected are not clearly visible to a user.

Flow is broken even with results existing in the given date range, and without any navigation (latest/older). What you describe is a different bug (two different bugs), both apparently fixed in the meantime (https://commons.wikimedia.org/w/index.php?title=Special:Contributions&target=Tacsipacsi&start=2022-06-04&end=2022-06-04 provides no results and https://commons.wikimedia.org/w/index.php?title=Special:Contributions&end=2022-06-05&start=2022-06-05&target=Tacsipacsi&limit=4 doesn’t let me navigate out of the range).

Change 881825 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] (Reverse|Range)ChronologicalPager: Use the effective offset

https://gerrit.wikimedia.org/r/881825

Change 885475 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Add range offsets to the ContribsPager::reallyDoQuery hook

https://gerrit.wikimedia.org/r/885475

Change 881825 abandoned by Func:

[mediawiki/core@master] pager: Fill the effective offset for range pagers

Reason:

See change I33e9005cdf27c993b3fe2bb20871d46ed02f26e3

https://gerrit.wikimedia.org/r/881825

Change 885476 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Flow@master] Use range offsets for listing contributions

https://gerrit.wikimedia.org/r/885476

Change 885475 abandoned by Func:

[mediawiki/core@master] Add range offsets to the ContribsPager::reallyDoQuery hook

Reason:

https://gerrit.wikimedia.org/r/885475

Change 881825 restored by Func:

[mediawiki/core@master] pager: Fill the effective offset for range pagers

https://gerrit.wikimedia.org/r/881825

Change 881825 merged by jenkins-bot:

[mediawiki/core@master] pager: Allow getting range offsets outside the subclass context

https://gerrit.wikimedia.org/r/881825

Change 885476 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Use range offsets for listing contributions

https://gerrit.wikimedia.org/r/885476

matmarex assigned this task to Func.

Thanks for the patches @Func!