Page MenuHomePhabricator
Create Task
Maniphest T167601

Transclusion of Special:NewImages produces a JavaScript error
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • Edit a page (using the wikitext editor, I don't know about VE)
  • Enter {{Special:NewImages}}
  • Preview the page
  • Observe an error "Widget not found: mw-input-start" in the browser's console.

This seems to have been caused by rMW3a7ce3d629ff: Date range filtering in Special:NewFiles, which caused Special:NewImages to add a RL module for affecting the special page's form without guarding it in if ( !$this->including() ) {.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SpecialNewimages: Do not add the module when the special page is includedmediawiki/corewmf/1.30.0-wmf.4+2 -1
SpecialNewimages: Do not add the module when the special page is includedmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.Jun 11 2017, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2017, 4:46 PM
Sn1per unsubscribed.Jun 11 2017, 4:49 PM
Sn1per subscribed.Jun 11 2017, 6:07 PM
Fomafix claimed this task.Jun 11 2017, 6:55 PM
Fomafix triaged this task as Medium priority.
gerritbot subscribed.Jun 11 2017, 6:55 PM

Change 358242 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] SpecialNewimages: Do not add module when special page is included

https://gerrit.wikimedia.org/r/358242

gerritbot added a project: Patch-For-Review.Jun 11 2017, 6:55 PM
gerritbot added a comment.Jun 12 2017, 6:13 AM

Change 358242 merged by jenkins-bot:
[mediawiki/core@master] SpecialNewimages: Do not add the module when the special page is included

https://gerrit.wikimedia.org/r/358242

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jun 12 2017, 7:01 AM
hashar edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes.Jun 12 2017, 8:45 AM
hashar subscribed.

I guess that deserves a backport to 1.30.0-wmf.4 ? :]

gerritbot added a comment.Jun 12 2017, 8:46 AM

Change 358320 had a related patch set uploaded (by Hashar; owner: Fomafix):
[mediawiki/core@wmf/1.30.0-wmf.4] SpecialNewimages: Do not add the module when the special page is included

https://gerrit.wikimedia.org/r/358320

gerritbot added a comment.Jun 12 2017, 1:42 PM

Change 358320 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.4] SpecialNewimages: Do not add the module when the special page is included

https://gerrit.wikimedia.org/r/358320

Stashbot subscribed.Jun 12 2017, 1:48 PM

Mentioned in SAL (#wikimedia-operations) [2017-06-12T13:48:34Z] <hashar@tin> Synchronized php-1.30.0-wmf.4/includes/specials/SpecialNewimages.php: SpecialNewimages: Do not add the module when the special page is included - T167601 (duration: 00m 41s)

hashar closed this task as Resolved.Jun 12 2017, 1:48 PM

Backported to 1.30.0-wmf.4 and I have confirmed that drop the notice + show the content of new page on preview.

Krinkle mentioned this in T168695: Special:NewFiles: Do date start/end swapping server-side instead of client-side.Jun 23 2017, 12:21 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits