Page MenuHomePhabricator
Create Task
Maniphest T167615

Auth_remoteuser breaks google custom search
Closed, ResolvedPublic
Actions

Description

I'm using MediaWiki 1.27.3 and (for historical reasons) https://www.mediawiki.org/wiki/Extension:Google_Custom_Search_Engine
Yes, I know it's unmaintained - but it still works as long as I don't use Auth_remoteuser.

After enabling Auth_remoteuser, I get an error that seems to be caused by and within Auth_remoteuser:

Exception encountered, of type "Error"
[e3aef083ed85d1b95ec40776] /MediaWiki:GoogleSearch?cx=013285077636246033335%3A2wluvjftece&cof=FORID%3A10&ie=UTF-8&q=whatever&sa=Search&siteurl=en-test.opensuse.org%2FMediaWiki%3AGoogleSearch&ref=&ss= Error from line 517 of /usr/share/mediawiki_1_27/extensions/Auth_remoteuser/src/UserNameSessionProvider.php: Call to a member function isKnown() on null
Backtrace:
#0 /usr/share/mediawiki_1_27/includes/Hooks.php(195): MediaWiki\Extensions\Auth_remoteuser\UserNameSessionProvider->MediaWiki\Extensions\Auth_remoteuser\{closure}(array, Title, SkinBento)
#1 /usr/share/mediawiki_1_27/includes/skins/SkinTemplate.php(708): Hooks::run(string, array)
#2 /usr/share/mediawiki_1_27/includes/skins/SkinTemplate.php(472): SkinTemplate->buildPersonalUrls()
#3 /usr/share/mediawiki_1_27/includes/skins/SkinTemplate.php(246): SkinTemplate->prepareQuickTemplate(OutputPage)
#4 /usr/share/mediawiki_1_27/includes/OutputPage.php(2327): SkinTemplate->outputPage()
#5 /usr/share/mediawiki_1_27/includes/MediaWiki.php(743): OutputPage->output()
#6 /usr/share/mediawiki_1_27/includes/MediaWiki.php(509): MediaWiki->main()
#7 /usr/share/mediawiki_1_27/index.php(43): MediaWiki->run()
#8 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Title::newFromText() can and does return nullmediawiki/extensions/Auth_remoteuserREL1_29+3 -2
Title::newFromText() can and does return nullmediawiki/extensions/Auth_remoteuserREL1_28+3 -2
Title::newFromText() can and does return nullmediawiki/extensions/Auth_remoteuserREL1_27+3 -2
Title::newFromText() can and does return nullmediawiki/extensions/Auth_remoteusermaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

Cboltz created this task.Jun 11 2017, 9:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2017, 9:26 PM
gerritbot subscribed.Jun 12 2017, 1:44 AM

Change 358305 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Auth_remoteuser@master] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358305

gerritbot added a project: Patch-For-Review.Jun 12 2017, 1:44 AM
Reedy subscribed.Jun 12 2017, 1:53 AM

The problem is Title::newFromText() can and does return null. The extension doesn't check for it. The patch above corrects that

There may be a problem with what it's storing in $this->userUrls[ 'logout' ]...

I can't obviously see where it's getting set

Reedy added a comment.Jun 12 2017, 3:04 AM

Ah, done by magic

					case 'userUrls':
						if ( is_array( $params[ $key ] ) ) {
							$value = $params[ $key ];
						}
						break;
gerritbot added a comment.Jun 12 2017, 3:50 AM

Change 358307 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Auth_remoteuser@REL1_27] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358307

gerritbot added a comment.Jun 12 2017, 3:50 AM

Change 358308 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Auth_remoteuser@REL1_28] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358308

gerritbot added a comment.Jun 12 2017, 3:50 AM

Change 358309 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Auth_remoteuser@REL1_29] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358309

Peachey88 updated the task description. (Show Details)Jun 12 2017, 3:56 AM
jrchamp subscribed.Jun 12 2017, 4:51 PM

Seems like a simple fix and it will address the specific issue. Nice find!

Cboltz added a comment.EditedJun 12 2017, 6:30 PM

Thanks for the quick response! I can confirm that the fix works :-) (tested on the 1.27 branch)

[question about backporting to 1.27 deleted after I noticed that you already did that ;-) ]

Reedy added a comment.Jun 12 2017, 6:32 PM

I have cherry picked it to all active/maintained branches. Just waiting on someone to code review it and merge them :)

gerritbot added a comment.Jun 13 2017, 8:33 AM

Change 358305 merged by jenkins-bot:
[mediawiki/extensions/Auth_remoteuser@master] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358305

gerritbot added a comment.Jun 13 2017, 8:33 AM

Change 358307 merged by jenkins-bot:
[mediawiki/extensions/Auth_remoteuser@REL1_27] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358307

gerritbot added a comment.Jun 13 2017, 8:33 AM

Change 358308 merged by jenkins-bot:
[mediawiki/extensions/Auth_remoteuser@REL1_28] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358308

gerritbot added a comment.Jun 13 2017, 8:33 AM

Change 358309 merged by jenkins-bot:
[mediawiki/extensions/Auth_remoteuser@REL1_29] Title::newFromText() can and does return null

https://gerrit.wikimedia.org/r/358309

Reedy closed this task as Resolved.Jun 13 2017, 4:52 PM
Reedy claimed this task.
Reedy triaged this task as Low priority.
Reedy removed a project: Patch-For-Review.
Enst80 mentioned this in T188193: update namespace.Feb 24 2018, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits