Regression: Page Previews not using normalised title in requests
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	phuedx
	Jun 12 2017, 8:23 AM

Description

Symptom

See below.

Example(s)

Dwelling on the "Yorkshire Terrier" link on https://en.wikipedia.beta.wmflabs.org/wiki/Dog causes the following HTTP requests:

Cause

This regression was introduced in rEPOP35bf61396451: eventLogging: Add missing *Hover properties.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	actions/rest: Use DB-key version of title	mediawiki/extensions/Popups	wmf/1.30.0-wmf.4	+8 -8
	actions/rest: Use DB-key version of title	mediawiki/extensions/Popups	master	+8 -8

Customize query in gerrit

Related Objects

Mentioned Here: rEPOP31f75683342b: actions/rest: Use DB-key version of title
rEPOP35bf61396451: eventLogging: Add missing *Hover properties

Event Timeline

phuedx created this task.Jun 12 2017, 8:23 AM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptJun 12 2017, 8:23 AM

• Jhernandez triaged this task as High priority.Jun 12 2017, 9:18 AM

• Jhernandez added a project: Readers-Web-Kanbanana-Board-Old.

• Jhernandez moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

• Jhernandez added a project: Unplanned-Sprint-Work.Jun 12 2017, 9:28 AM

• Jhernandez added a project: Regression.

Change 358338 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@master] actions/rest: Use DB-key version of title

https://gerrit.wikimedia.org/r/358338

gerritbot added a project: Patch-For-Review.Jun 12 2017, 10:22 AM

• Jhernandez claimed this task.Jun 12 2017, 10:28 AM

• Jhernandez reassigned this task from • Jhernandez to phuedx.

• Jhernandez moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

• Jhernandez subscribed.

phuedx moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 12 2017, 10:30 AM

Change 358338 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] actions/rest: Use DB-key version of title

https://gerrit.wikimedia.org/r/358338

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 12 2017, 11:00 AM

pmiazga subscribed.Jun 12 2017, 11:01 AM

phuedx moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jun 12 2017, 11:07 AM

phuedx updated the task description. (Show Details)

Better! Dwelling on the link now causes the following HTTP request:

phuedx removed phuedx as the assignee of this task.Jun 12 2017, 11:10 AM

ovasileva moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog-Archived board.Jun 12 2017, 3:25 PM

Today I noticed a significant latency regression for page previews, and @Pchelolo realized that this task might be the explanation. A large percentage of requests now get redirect responses, which increased overall latency significantly:

I can backport the fix and deploy it either this evening or tomorrow morning (BST) /cc @Jdlrobson

I'll sign off/swat today.

The patch can't be cleanly picked to wmf/1.30.0-wmf.4 (even if I do that manually and run npm run compile)
The change looks good, but @phuedx would you mind doing the SWATing?
I don't think I'm going to make it till 4pm today :(

• mobrovac edited projects, added Services (watching); removed Services.Jun 12 2017, 7:36 PM

In T167633#3342006, @Jdlrobson wrote:

The patch can't be cleanly picked to wmf/1.30.0-wmf.4 (even if I do that manually and run npm run [build])
The change looks good, but @phuedx would you mind doing the SWATing?

Sure! Thanks for picking it up in the first place!

phuedx moved this task from Ready for Signoff to Doing on the Readers-Web-Kanbanana-Board-Old board.Jun 13 2017, 8:27 AM

Change 358528 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@wmf/1.30.0-wmf.4] actions/rest: Use DB-key version of title

https://gerrit.wikimedia.org/r/358528

I've scheduled rEPOP31f75683342b: actions/rest: Use DB-key version of title to be deployed during today's European Mid-day SWAT deployment.

Change 358528 merged by jenkins-bot:
[mediawiki/extensions/Popups@wmf/1.30.0-wmf.4] actions/rest: Use DB-key version of title

https://gerrit.wikimedia.org/r/358528

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 13 2017, 1:00 PM

Mentioned in SAL (#wikimedia-operations) [2017-06-13T13:13:40Z] <hashar@tin> Synchronized php-1.30.0-wmf.4/extensions/Popups: actions/rest: Use DB-key version of title - T167633 (duration: 00m 41s)

Latency is back to normal:

Per T167633#3344820.

phuedx moved this task from Doing to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jun 13 2017, 2:23 PM

	F8444059: Screen Shot 2017-06-12 at 12.07.27.png
	Jun 12 2017, 11:10 AM

	F8443564: Screen Shot 2017-06-12 at 08.45.26.png
	Jun 12 2017, 8:23 AM

	F8452255: image.png
	Jun 13 2017, 2:09 PM

	F8445379: image.png
	Jun 12 2017, 5:09 PM

Regression: Page Previews not using normalised title in requestsClosed, ResolvedPublic1 Estimated Story PointsActions