Page MenuHomePhabricator
Create Task
Maniphest T167687

Special:ExpandTemplates does not load module 'mediawiki.toc'
Closed, DeclinedPublic
Actions

Description

Steps to reproduce:

Current result: The TOC does not have a button to hide the TOC.
Expected result: The TOC should have a button to hide the TOC. This is occurs when the module mediawiki.toc is loaded.

The module mediawiki.toc is a less important module. But there may be more important module which should be loaded also an ExpandTemplate preview.

Related Objects

Event Timeline

Fomafix created this task.Jun 12 2017, 3:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2017, 3:16 PM
Fomafix added a comment.Jun 12 2017, 3:42 PM

The module 'mediawiki.page.gallery' gets loaded on expand template preview when including https://www.mediawiki.org/wiki/Help:Images with {{:Help:Images}} but not the module mediawiki.toc.

Fomafix added a comment.Jun 12 2017, 3:48 PM

Before c7e00974c7eb1cd33783f4f0354de766e70ce3c1 Special:ExpandTemplates loaded the module mediawiki.toc on preview.

Fomafix edited projects, added MediaWiki-Special-pages, Regression; removed MediaWiki-extensions-ExpandTemplates.Jun 12 2017, 4:06 PM
Krinkle subscribed.Jun 12 2017, 5:11 PM

This seems by design. SpecialExpandTemplates calls OutputPage::addParserOutputContent which intentionally does not call addParserOutputMetadata.

This means that the following don't apply on ExpandTemplates:

  • Language links, Indicators. (Sidebar, Header)
  • Talk link / New section link. (Navigation tabs)
  • Parser limit report. (Invisible - HTML comment)

And more things, such as loading of OOUI, and indeed (as of c7e00974c7e) the loading of mediawiki.toc.

I think this is by design given the page is not meant to be an interactive preview for reading, but rather, just showing the plain HTML as it would be after the Parser expands the template.

If this should be more like edit preview, then one would need to call addParserOutput() instead. But that may do unexpected things. Worth a try?

Izno moved this task from To triage to Special:ExpandTemplates on the MediaWiki-Special-pages board.Aug 2 2017, 12:08 PM
Krinkle closed this task as Declined.Jul 8 2018, 9:10 PM

Declining for now. ExpandTemplates has never been an accurate edit preview. Specifically, any visual rendering controlled by the skin is intentionally excluded. This means that the special page will not have categories, language links, "Edit" tab, "New section", "View history" tab etc. It also does not get Skin-controlled modifications, such as customised edit-section links, and (as of last year) interactive table of contents.

I understand that the lack of interactive TOC may seem like a regression, but in this case it is not specific to TOC. The TOC implementation merely moved from one area to another, and the other area was already intentionally disabled.

The output renders without problems though, and there are no broken buttons (e.g. it's not like the TOC shows a "hide" button that doesn't work, it just renders correctly without the interactive part).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL