Page MenuHomePhabricator
Create Task
Maniphest T167710

[Regression wmf.4] "Show options" button is disabled in the template dialog while trying to re-edit it
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open VE
  2. Go to Insert>Template
  3. Search for a template say "Citation needed" and select it
  4. Click on "Add template" button
  5. Observe that at this point the "Show options" button is enabled.

6.Insert it

  1. Click on Edit on the context menu to reopen the dialog.

The "Show options" button is disabled now.

Details

SubjectRepoBranchLines +/-
MWTransclusionDialog: fix conditions for "show options" button disablingmediawiki/extensions/VisualEditormaster+27 -7
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jun 12 2017, 5:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2017, 5:48 PM
• Deskana triaged this task as High priority.Jun 12 2017, 6:09 PM
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

This is broken in production.

Jdforrester-WMF added a project: VisualEditor-MediaWiki-Templates.Jun 12 2017, 6:37 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF renamed this task from [Regression ?] "Show options" button is disabled in the template dialog while trying to re-edit it to [Regression wmf.4] "Show options" button is disabled in the template dialog while trying to re-edit it.Jun 12 2017, 6:41 PM
Jdforrester-WMF mentioned this in T167483: [Regression wmf.4] Dialog footer broken for templates.
gerritbot subscribed.Jun 14 2017, 3:55 PM

Change 358984 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWTransclusionDialog: fix conditions for "show options" button disabling

https://gerrit.wikimedia.org/r/358984

gerritbot added a project: Patch-For-Review.Jun 14 2017, 3:55 PM
gerritbot added a comment.Jun 23 2017, 5:21 PM

Change 358984 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWTransclusionDialog: fix conditions for "show options" button disabling

https://gerrit.wikimedia.org/r/358984

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jun 23 2017, 6:00 PM
• Deskana closed this task as Resolved.Jun 26 2017, 9:57 AM
• Deskana assigned this task to DLynch.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 26 2017, 9:57 AM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.Jun 26 2017, 5:46 PM
Ryasmeen added a project: Verified-in-Phase0.Jun 29 2017, 12:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL