Page MenuHomePhabricator

LoginNotify checks should be asynchronous
Closed, ResolvedPublic5 Estimated Story Points

Description

In my admittedly unscientific testing, logging in an account present on every wiki takes ~5 seconds from enwiki and 8-9 seconds on testwiki. The difference is likely due to LoginNotify (specifically, it calling the brutally slow CentralAuthUser::queryAttached). The solution would be to move processing of failed logins to job queue.

Event Timeline

Let's make the cross-wiki checks happen in a deferred Job Queue job.

kaldari set the point value for this task to 5.

Change 360787 had a related patch set uploaded (by Legoktm; owner: MaxSem):
[mediawiki/extensions/LoginNotify@master] Move expensive processing into job queue

https://gerrit.wikimedia.org/r/360787