Page MenuHomePhabricator

Correctly set lang HTML attribute for each article placeholder string
Open, Needs TriagePublic

Description has a label and description in English, but they're both marked as being in Welsh (cy), either implicitly or explicitly:

<h1 id="firstHeading" class="firstHeading" lang="cy">Wanfried agreement</h1>

Every label and description (also for properties and statements thereof) should come with its lang attribute, when we fallback to a language different from the content language.


Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptJun 14 2017, 12:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Nemo_bis updated the task description. (Show Details)Jun 14 2017, 3:45 PM

LanguageFallbackChain::extractPreferredValue() returns a language value which should be what we need, if it's passed on in the next steps; TermIndexEntry provides a getLanguage() function. mentions mw.wikibase.entity:getLabelWithLang and mw.wikibase.entity:getDescriptionWithLang

Change 358998 had a related patch set uploaded (by Nemo bis; owner: Federico Leva):
[mediawiki/extensions/ArticlePlaceholder@master] [WIP] Identify some places where the lang attribute would be needed

hoo added a subscriber: hoo.Jun 18 2017, 9:50 AM