Page MenuHomePhabricator
Create Task
Maniphest T168080

Vector's dropdown menus are not keyboard-accessible without JavaScript
Closed, ResolvedPublic
Actions

Description

Vector's dropdown menus are not keyboard-accessible without JavaScript.

image.png (566×1 px, 92 KB)

With JavaScript enabled, there's a little script that makes the dropdown menu handles focusable and handles keypresses on them to display the menu (T26298). But grade C browsers and users without JavaScript are left out in the cold.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove old selectors and JavaScript for dropdown menusmediawiki/skins/Vectormaster+2 -23
Make dropdown menus keyboard-accessible without JavaScriptmediawiki/skins/Vectormaster+38 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jun 16 2017, 5:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2017, 5:11 PM
gerritbot subscribed.Jun 16 2017, 5:22 PM

Change 359474 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Vector@master] Make dropdown menus keyboard-accessible without JavaScript

https://gerrit.wikimedia.org/r/359474

gerritbot added a project: Patch-For-Review.Jun 16 2017, 5:22 PM

Change 359475 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Vector@master] Remove old selectors and JavaScript for dropdown menus

https://gerrit.wikimedia.org/r/359475

matmarex claimed this task.Jun 16 2017, 5:22 PM
matmarex triaged this task as Low priority.
gerritbot added a comment.Feb 7 2018, 12:30 AM

Change 359474 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Make dropdown menus keyboard-accessible without JavaScript

https://gerrit.wikimedia.org/r/359474

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 7 2018, 1:00 AM
matmarex closed this task as Resolved.Feb 7 2018, 2:02 AM
matmarex removed a project: Patch-For-Review.

\o/

Volker_E added a project: Accessibility.Feb 7 2018, 8:59 AM
gerritbot added a comment.Mar 12 2018, 11:40 PM

Change 359475 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove old selectors and JavaScript for dropdown menus

https://gerrit.wikimedia.org/r/359475

Krinkle moved this task from Needs triage to Design on the Vector (legacy skin) board.Mar 12 2018, 11:54 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Mar 13 2018, 12:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits