Page MenuHomePhabricator

Unbalanced margin/padding around RC filters
Closed, ResolvedPublic

Description

image.png (112×481 px, 13 KB)

The top margin is only 0.3em, whereas the other are all 0.6em. Furthermore there is extra spacing under the filter tag list making it seem ever more unbalanced.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 359626 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Correct unbalanced margins in active filters display

https://gerrit.wikimedia.org/r/359626

Change 359626 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Correct unbalanced margins in active filters display

https://gerrit.wikimedia.org/r/359626

Checked the fix in betalabs:

Screen Shot 2017-06-23 at 9.14.51 AM.png (243×1 px, 55 KB)

Just for comparison - the margins/padding in the prototype

Screen Shot 2017-06-23 at 9.13.38 AM.png (179×1 px, 40 KB)

QA Recommendation: Resolve