Page MenuHomePhabricator

Filter callouts anchored to close icons, instead of whole label
Closed, ResolvedPublic

Description

This looks like the callout is specific to the close button. It should either be centred on the label or the whole tag.

Details

Related Gerrit Patches:

Event Timeline

Esanders created this task.Jun 16 2017, 8:11 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 16 2017, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 359624 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Reposition TagItemWidget to be center on the widget

https://gerrit.wikimedia.org/r/359624

Change 359624 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Reposition TagItemWidget to be center on the widget

https://gerrit.wikimedia.org/r/359624

Checked the fix in betalabs - the callout is placed centrally.

The fix is according to the prototype (http://pauginer.github.io/prototypes/edit-review/extended-filters/index.html), except for the background color of the callout:

QA Recommendation: Resolve

the callout is [now placed] centrally

Actually it's still slightly to the right of centre:

by ~20px

jmatazzoni closed this task as Resolved.Jul 14 2017, 1:06 AM

@Esanders is right—and wrong. The callout is now centered on the tag itself, which was the issue here. So I'm closing this ticket.

However, the little pointer that's part of the callout is not centered in the callout. I'm not sure how it's positioned, exactly, but it's always positioned to the right side of the callout. I don't find this objectionable, but I don't know what the intention here is .@Pginer-WMF, is that something you want to fix.

the little pointer that's part of the callout is not centered in the callout. I'm not sure how it's positioned, exactly, but it's always positioned to the right side of the callout. I don't find this objectionable, but I don't know what the intention here is .@Pginer-WMF, is that something you want to fix.

The biggest issue for me was the tooltip pointing to the "X" icon in the original screenshot. Now it can be seen pointing to the main tag body.
Ideally, we'd like the tip to be perfectly centered, but we also would like the tooltip to better adapt to the length of the content. So I guess a general ticket to improve the tooltip components in general can be a next step.