Page MenuHomePhabricator
Create Task
Maniphest T168240

WBQC test improvements
Closed, ResolvedPublic
Actions

Description

  • Use NewItem and NewStatement instead of JsonFileEntityLookup (see also InMemoryEntityLookup)
  • Format according to Arrange-Act-Assert
  • Add helper methods to create constraint parameters once we no longer support the concise template format (instead of copy+pasting the snak construction + serialization everywhere)

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 19 2017, 9:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2017, 9:27 AM
gerritbot subscribed.Jun 19 2017, 9:27 AM

Change 359911 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Start using NewItem in tests

https://gerrit.wikimedia.org/r/359911

gerritbot added a project: Patch-For-Review.Jun 19 2017, 9:27 AM
gerritbot added a comment.Jun 28 2017, 1:22 PM

Change 359911 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Start using NewItem in tests

https://gerrit.wikimedia.org/r/359911

gerritbot added a comment.Jun 30 2017, 12:22 PM

Change 362395 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add {class,relation}Parameter to ConstraintParameters

https://gerrit.wikimedia.org/r/362395

gerritbot added a comment.Jul 3 2017, 1:08 PM

Change 362984 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use NewStatement in tests

https://gerrit.wikimedia.org/r/362984

gerritbot added a comment.Jul 3 2017, 4:01 PM

Change 362984 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use NewStatement in tests

https://gerrit.wikimedia.org/r/362984

thiemowmde triaged this task as Low priority.Jul 4 2017, 8:42 AM
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde added a subscriber: • Jonas.
gerritbot added a comment.Jul 13 2017, 4:49 PM

Change 365060 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use NewItem NewStatement in DiffWithinRangeCheckerTest

https://gerrit.wikimedia.org/r/365060

gerritbot added a comment.Jul 17 2017, 11:07 AM

Change 365060 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use NewItem NewStatement in DiffWithinRangeCheckerTest

https://gerrit.wikimedia.org/r/365060

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 17 2017, 11:10 AM
Lucas_Werkmeister_WMDE added a subtask: T172378: Migrate tests to constraint statement parameters.Aug 3 2017, 11:41 AM
Lucas_Werkmeister_WMDE closed subtask T172378: Migrate tests to constraint statement parameters as Resolved.Aug 22 2017, 9:59 AM
gerritbot added a comment.Aug 30 2017, 4:36 PM

Change 374841 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove SnakSerializer use from OneOfCheckerTest

https://gerrit.wikimedia.org/r/374841

gerritbot added a comment.Aug 31 2017, 1:11 PM

Change 374841 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove SnakSerializer use from OneOfCheckerTest

https://gerrit.wikimedia.org/r/374841

gerritbot added a comment.Nov 17 2017, 1:15 PM

Change 392040 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in RangeCheckerTest

https://gerrit.wikimedia.org/r/392040

gerritbot added a comment.Nov 21 2017, 10:00 AM

Change 392040 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in RangeCheckerTest

https://gerrit.wikimedia.org/r/392040

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 21 2017, 11:00 AM
gerritbot added a comment.Nov 23 2017, 11:46 AM

Change 393055 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in QualifiersCheckerTest

https://gerrit.wikimedia.org/r/393055

gerritbot added a comment.Nov 27 2017, 8:10 AM

Change 393055 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use JsonFileEntityLookup in QualifiersCheckerTest

https://gerrit.wikimedia.org/r/393055

gerritbot added a comment.Jan 17 2018, 4:42 PM

Change 404715 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use InMemoryEntityLookup instead of JsonFileEntityLookup

https://gerrit.wikimedia.org/r/404715

gerritbot added a comment.Jan 18 2018, 6:19 PM

Change 405032 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountChecker tests

https://gerrit.wikimedia.org/r/405032

gerritbot added a comment.Jan 22 2018, 3:27 PM

Change 405724 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename @dataProvider methods to provide…()

https://gerrit.wikimedia.org/r/405724

gerritbot added a comment.Jan 23 2018, 1:38 PM

Change 405874 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed …->withSomeGuid() calls from tests

https://gerrit.wikimedia.org/r/405874

gerritbot added a comment.Jan 23 2018, 2:08 PM

Change 405724 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename @dataProvider methods to provide…()

https://gerrit.wikimedia.org/r/405724

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Jan 23 2018, 3:00 PM
gerritbot added a comment.Jan 23 2018, 3:28 PM

Change 405032 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountChecker tests

https://gerrit.wikimedia.org/r/405032

gerritbot added a comment.Jan 23 2018, 3:41 PM

Change 405874 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed …->withSomeGuid() calls from tests

https://gerrit.wikimedia.org/r/405874

gerritbot added a comment.Jan 23 2018, 4:04 PM

Change 405893 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Expand ReferenceContextTest::testGetSnakGroup

https://gerrit.wikimedia.org/r/405893

gerritbot added a comment.Jan 23 2018, 4:14 PM

Change 405897 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use NewStatement to build standalone snaks

https://gerrit.wikimedia.org/r/405897

gerritbot added a comment.Jan 24 2018, 12:11 PM

Change 405893 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Expand ReferenceContextTest::testGetSnakGroup

https://gerrit.wikimedia.org/r/405893

gerritbot added a comment.Jan 24 2018, 12:11 PM

Change 405897 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use NewStatement to build standalone snaks

https://gerrit.wikimedia.org/r/405897

gerritbot added a comment.Jan 24 2018, 2:38 PM

Change 404715 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use InMemoryEntityLookup instead of JsonFileEntityLookup

https://gerrit.wikimedia.org/r/404715

Lydia_Pintscher subscribed.Feb 13 2018, 3:28 PM

Anything left to do here or can this be closed?

Lucas_Werkmeister_WMDE added a comment.Feb 13 2018, 3:34 PM

We still have some uses of JsonEntityLookup in the tests, so that part of the original task description is still open. Apart from that, I’ve kinda been using this task as a catch-all for various stuff I did in the tests… not sure if that makes sense.

Lydia_Pintscher moved this task from incoming to other on the Wikibase-Quality-Constraints board.Apr 6 2018, 4:06 PM
Addshore subscribed.Sep 18 2018, 11:59 AM

@Lucas_Werkmeister_WMDE It might be nice to wrap this task up and close it filing a new with the remaining JsonEntityLookup and tagging with Wikidata-Campsite ready to be picked up in future iterations.

Addshore added a project: [DEPRECATED] wdwb-tech.Sep 18 2018, 11:59 AM
Addshore moved this task from Inbox to Blocked on the [DEPRECATED] wdwb-tech board.
Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 18 2018, 12:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL