Page MenuHomePhabricator

Question Mark Icon Stays Highlighted
Closed, InvalidPublic

Description

Revision slider help icon stays highlighted after clicking through the help dialog.

Expected Behavior: the question mark shouldn't be highlighted after the click.

See gif

Page where this can be reproduced

Present in

Chromium Version 58.0.3029.110 Ubuntu 16.04 (64-bit)
Firefx Version 54.0 Ubuntu 16.04 (64-bit)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2017, 10:35 AM

I guess this has the same reason as for the open/collapse button of the RS. AFAIK this behavior comes from OOjs-UI.

This bug is present in the current deployed revision slider as well.

TheDJ added a subscriber: TheDJ.Jul 28 2017, 1:43 PM

I guess this has the same reason as for the open/collapse button of the RS. AFAIK this behavior comes from OOjs-UI.

Yes, this is an accessibility feature and it allows keyboard/screenreader dependant users to return to the point in the document where they came from when closing the modal dialog. It is intentional.

If the focus isn't shifted to something new, then it will stay where it is. As hovering over a slider is not an focusable interaction, the focus is not resigned.

WMDE-Fisch closed this task as Invalid.Jul 31 2017, 7:39 AM

Yes, this is an accessibility feature and it allows keyboard/screenreader dependant users to return to the point in the document where they came from when closing the modal dialog. It is intentional.

Thanks for the clarification here. Makes sense to me and I will close this ticket.