Page MenuHomePhabricator

Adjust spacing for cards
Open, NormalPublic

Description

The general style for cards was captured in T158410 is not always consistently applied. In particular, vertical space is not always balanced and the dividing lines don't go from edge to edge as captured in the guidelines:

Some examples of cards form CX2 that need some polishing:

  • Separator line not going from edge to edge (as indicated by the green circles).
  • Space above and below the separator should be 8px to make the control below to be balanced in terms of vertical space.
  • The "template name" is not aligned with the other labels as indicated by the red line.

  • Separator line not going from edge to edge (as indicated by the green circles).
  • Use standard distance modules (8px) as vertical separation for the drop-down (in red) and the "keep as default" action (in blue).

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusAssignedTask
OpenAmire80
OpenNone

Event Timeline

santhosh updated the task description. (Show Details)Jun 20 2017, 6:19 AM
santhosh added a subscriber: santhosh.
Amire80 moved this task from Needs Triage to CX2 on the ContentTranslation board.Jun 25 2017, 8:15 PM
Pginer-WMF triaged this task as Normal priority.Jun 30 2017, 9:52 AM

Change 370200 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] CX2: Adjust spacing for cards

https://gerrit.wikimedia.org/r/370200

@Pginer-WMF Here are some screenshots, so you don't need to download patch to review it.
Same patch addresses two tickets, other one being T168283

@Pginer-WMF Here are some screenshots, so you don't need to download patch to review it.

Looks good. Thanks!

Change 370200 abandoned by Petar.petkovic:
CX2: Adjust spacing for cards

Reason:
No longer needed.

https://gerrit.wikimedia.org/r/370200

@Pginer-WMF, is this ticket still valid for CX2?

@Pginer-WMF, is this ticket still valid for CX2?

With the integration of Visual Editor inspectors, this needs to be updated since internal padding changed. The separation between cards is still valid.

Petar.petkovic removed Petar.petkovic as the assignee of this task.Jul 28 2018, 11:35 PM