Page MenuHomePhabricator

Adjust spacing for cards
Open, MediumPublic

Assigned To
None
Authored By
Pginer-WMF
Jun 19 2017, 11:12 AM
Referenced Files
F8946641: template.PNG
Aug 4 2017, 2:01 PM
F8946642: instructions.PNG
Aug 4 2017, 2:01 PM
F8946640: all.png
Aug 4 2017, 2:01 PM
F8478353: template-card-issues.png
Jun 19 2017, 11:12 AM
F5668482: CX-translation-cards-spec.png
Jun 19 2017, 11:12 AM
F8478380: mt-card-issues.png
Jun 19 2017, 11:12 AM

Description

The general style for cards was captured in T158410 is not always consistently applied. In particular, vertical space is not always balanced and the dividing lines don't go from edge to edge as captured in the guidelines:

CX-translation-cards-spec.png (341×333 px, 7 KB)

Some examples of cards form CX2 that need some polishing:

template-card-issues.png (174×433 px, 12 KB)

  • Separator line not going from edge to edge (as indicated by the green circles).
  • Space above and below the separator should be 8px to make the control below to be balanced in terms of vertical space.
  • The "template name" is not aligned with the other labels as indicated by the red line.

mt-card-issues.png (216×445 px, 14 KB)

  • Separator line not going from edge to edge (as indicated by the green circles).
  • Use standard distance modules (8px) as vertical separation for the drop-down (in red) and the "keep as default" action (in blue).

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
ResolvedPginer-WMF
OpenNone

Event Timeline

Pginer-WMF triaged this task as Medium priority.Jun 30 2017, 9:52 AM

Change 370200 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] CX2: Adjust spacing for cards

https://gerrit.wikimedia.org/r/370200

@Pginer-WMF Here are some screenshots, so you don't need to download patch to review it.
Same patch addresses two tickets, other one being T168283

instructions.PNG (322×626 px, 14 KB)

template.PNG (295×619 px, 11 KB)

all.png (667×618 px, 25 KB)

@Pginer-WMF Here are some screenshots, so you don't need to download patch to review it.

Looks good. Thanks!

Change 370200 abandoned by Petar.petkovic:
CX2: Adjust spacing for cards

Reason:
No longer needed.

https://gerrit.wikimedia.org/r/370200

@Pginer-WMF, is this ticket still valid for CX2?

With the integration of Visual Editor inspectors, this needs to be updated since internal padding changed. The separation between cards is still valid.