When supporting this, we want to make sure that links open in a new window as reported in T146761 (and close that ticket once we check it works as expected in the new version)

Change 465766 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Warning about article changed too much

https://gerrit.wikimedia.org/r/465766

Change 466800 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Allow additional buttons in the issue card

https://gerrit.wikimedia.org/r/466800

Change 466977 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Implement "Restart the translation" functionality

https://gerrit.wikimedia.org/r/466977

The "Restart.." button should probably be destructive? cf discard changes:

In T168287#4662549, @Esanders wrote:

The "Restart.." button should probably be destructive? cf discard changes:

Makes sense. The restart button is intended to both destroy (the old) and start (the new), but it is true that the purpose of the dialog is mainly to confirm that the user is ok with losing the existing data and can benefit from the extra emphasis. Let's make the restart button in the dialog to be destructive.

The published patch does include 'destructive' flag. What is proposed is to add 'primary' flag to already added 'destructive' flag. For comparison, here are 'primary' and 'destructive' flags used when deleting a draft on CX:

@Pginer-WMF which style should be used for the "Restart the translation" dialog? primary destructive or just destructive?

In T168287#4665752, @Petar.petkovic wrote:

@Pginer-WMF which style should be used for the "Restart the translation" dialog? primary destructive or just destructive?

Thanks for the clarification @Petar.petkovic. I'd go with both primary destructive.
In this case "primary" helps to mark which is the default path forward, and "destructive" helps the user not to just move to the default direction without thinking.

Change 467330 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Allow to resolve unattached issues

https://gerrit.wikimedia.org/r/467330

Once published, the translation cannot be restarted. When same translation is started again, the latest draft created before publishing is loaded.

While reviewing my patches, @Nikerabbit pointed out that we should bring this question up for discussion here.
Some of the proposed ways to deal with lack of the ability to restart the translation are:

• Detect it and don't offer the functionality to "Restart the translation"
• Skip detection, but add a note along the lines "if this article was previously published, this won't work"

In T168287#4667894, @Petar.petkovic wrote:

Once published, the translation cannot be restarted. When same translation is started again, the latest draft created before publishing is loaded.

While reviewing my patches, @Nikerabbit pointed out that we should bring this question up for discussion here.
Some of the proposed ways to deal with lack of the ability to restart the translation are:

• Detect it and don't offer the functionality to "Restart the translation"
• Skip detection, but add a note along the lines "if this article was previously published, this won't work"

I'd propose to detect the problematic case and don't offer the functionality in such case, until T192065 gets resolved (I'll add a note to that ticket so that we don't forget to undo this then).

Change 465766 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Warning about article changed too much

https://gerrit.wikimedia.org/r/465766

Change 467330 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Allow to resolve unattached issues

https://gerrit.wikimedia.org/r/467330

Change 466800 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Allow additional buttons in the issue card

https://gerrit.wikimedia.org/r/466800

@Pginer-WMF When restart option is not provided, we still display the same description: You can continue this translation, or start it again to use the updated content. If you restart the translation, your current changes will be lost.

Should we have a separate description for this case?

Change 466977 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Implement "Restart the translation" functionality

https://gerrit.wikimedia.org/r/466977

In T168287#4665752, @Petar.petkovic wrote:

The issue of the label extending to the edges of the button has been reported as a separate ticket: T207369: Embedded buttons in dialogs lack padding

First mockup from the description displays issue summary as a warning panel below publish button line. It is supposed to provide link to open card with details about issue.

That feature is yet to be supported in issue card system T189488. There is another ticket waiting on that feature - T192144.

In T168287#4687084, @Petar.petkovic wrote:

That feature is yet to be supported in issue card system T189488. There is another ticket waiting on that feature - T192144.

I see two options to move forward:

• Consider the feature part of T192144 and support both the improvements in the general framework as well as the specific case where it is needed. The fact that one piece of the solution is reusable for other tickets it does not necessarily mean we exclude it from the scope of these tickets.
• Creating a separate ticket for such improvement if that helps to have more focused tasks (the ticket about the card system is too general).

I was assuming the first way, but we can go with the second if that's needed for tickets not to be waiting.

In T168287#4691480, @Pginer-WMF wrote:

In T168287#4687084, @Petar.petkovic wrote:

That feature is yet to be supported in issue card system T189488. There is another ticket waiting on that feature - T192144.

I see two options to move forward:

• Consider the feature part of T192144 and support both the improvements in the general framework as well as the specific case where it is needed. The fact that one piece of the solution is reusable for other tickets it does not necessarily mean we exclude it from the scope of these tickets.
• Creating a separate ticket for such improvement if that helps to have more focused tasks (the ticket about the card system is too general).

I was assuming the first way, but we can go with the second if that's needed for tickets not to be waiting.

I prefer new ticket, so that would be option number 2.
There are multiple tasks which require the feature of connecting error message with issue card details and would be great to list tickets which depend on such feature, such as this one and T192144.

In T168287#4691562, @Petar.petkovic wrote:

In T168287#4691480, @Pginer-WMF wrote:

In T168287#4687084, @Petar.petkovic wrote:

That feature is yet to be supported in issue card system T189488. There is another ticket waiting on that feature - T192144.

I see two options to move forward:

• Consider the feature part of T192144 and support both the improvements in the general framework as well as the specific case where it is needed. The fact that one piece of the solution is reusable for other tickets it does not necessarily mean we exclude it from the scope of these tickets.
• Creating a separate ticket for such improvement if that helps to have more focused tasks (the ticket about the card system is too general).

I was assuming the first way, but we can go with the second if that's needed for tickets not to be waiting.

I prefer new ticket, so that would be option number 2.
There are multiple tasks which require the feature of connecting error message with issue card details and would be great to list tickets which depend on such feature, such as this one and T192144.

Ok. I created T207939: CX2: Access more details from the issue summary in a card
Feel free to add any comment there.

Change 470797 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Connect infobar with issue card

https://gerrit.wikimedia.org/r/470797

Change 470797 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Connect infobar with issue card

https://gerrit.wikimedia.org/r/470797

In T168287#4816117, @Etonkovidova wrote:

All looks according to the specs (the link "Learn more" is not present in the issue card and it's not described in the specs):

Thanks for checking. I'll take note to make sure that once the documentation pages are available (T203152), the learn more link is added pointing to the corresponding one.